Skip to content

RFC Split IOMMU DMA mapping operation to two steps

Leon Romanovsky kvm linux-block linux-doc linux-iommu linux-mm linux-nvme linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest16 patches 53 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16mm/hmm: let users to tag specific PFNsinclude/linux/hmm.h mm/hmm.c+24 -130 replies
2/16dma-mapping: provide an interface to allocate IOVAinclude/linux/dma-map-ops.h include/linux/dma-mapping.h kernel/dma/mapping.c+53 -00 replies
3/16dma-mapping: provide callbacks to link/unlink pages to specific IOVAinclude/linux/dma-map-ops.h include/linux/dma-mapping.h kernel/dma/debug.h +2 more+85 -00 replies
4/16iommu/dma: Provide an interface to allow preallocate IOVAdrivers/iommu/dma-iommu.c+38 -120 replies
5/16iommu/dma: Prepare map/unmap page functions to receive IOVAdrivers/iommu/dma-iommu.c+45 -230 replies
6/16iommu/dma: Implement link/unlink page callbacksdrivers/iommu/dma-iommu.c+17 -00 replies
7/16RDMA/umem: Preallocate and cache IOVA for UMEM ODPdrivers/infiniband/core/umem_odp.c include/rdma/ib_umem_odp.h include/rdma/ib_verbs.h+34 -10 replies
8/16RDMA/umem: Store ODP access mask information in PFNdrivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/odp.c +1 more+59 -910 replies
9/16RDMA/core: Separate DMA mapping to caching IOVA and page linkagedrivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/odp.c include/rdma/ib_umem_odp.h +1 more+61 -620 replies
10/16RDMA/umem: Prevent UMEM ODP creation with SWIOTLBDocumentation/core-api/dma-attributes.rst drivers/infiniband/core/umem_odp.c include/linux/dma-mapping.h +2 more+58 -400 replies
11/16vfio/mlx5: Explicitly use number of pages instead of allocated lengthdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h drivers/vfio/pci/mlx5/main.c+62 -440 replies
12/16vfio/mlx5: Rewrite create mkey flow to allow better code reusedrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h+88 -640 replies
13/16vfio/mlx5: Explicitly store page listdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h drivers/vfio/pci/mlx5/main.c+19 -180 replies
14/16vfio/mlx5: Convert vfio to use DMA link APIdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h drivers/vfio/pci/mlx5/main.c+91 -1440 replies
15/16block: add dma_link_range() based APIblock/blk-merge.c include/linux/blk-mq.h+165 -00 replies
16/16nvme-pci: use blk_rq_dma_map() for NVMe SGLdrivers/nvme/host/pci.c+49 -17110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC RESEND 00/16] Split IOMMU DMA mapping operation to two steps

This is complimentary part to the proposed LSF/MM topic.
https://lore.kernel.org/linux-rdma/[email protected]/T/#m85672c860539fdbbc8fe0f5ccabdc05b40269057

This is posted as RFC to get a feedback on proposed split, but RDMA, VFIO and DMA patches are ready for review and inclusion, the NVMe patches are still in progress as they require agreement on API first.

Thanks

-------------------------------------------------------------------------------
The DMA mapping operation performs two steps at one same time: allocates IOVA space and actually maps DMA pages to that space. This one shot operation works perfectly for non-complex scenarios, where callers use that DMA API in control path when they setup hardware.

However in more complex scenarios, when DMA mapping is needed in data path and especially when some sort of specific datatype is involved, such one shot approach has its drawbacks.

That approach pushes developers to introduce new DMA APIs for specific datatype. For example existing scatter-gather mapping functions, or latest Chuck's RFC series to add biovec related DMA mapping [1] and probably struct folio will need it too.

These advanced DMA mapping APIs are needed to calculate IOVA size to allocate it as one chunk and some sort of offset calculations to know which part of IOVA to map.

Instead of teaching DMA to know these specific datatypes, let's separate existing DMA mapping routine to two steps and give an option to advanced callers (subsystems) perform all calculations internally in advance and map pages later when it is needed.

In this series, three users are converted and each of such conversion presents different positive gain:
1. RDMA simplifies and speeds up its pagefault handling for on-demand-paging (ODP) mode.
2. VFIO PCI live migration code saves huge chunk of memory.
3. NVMe PCI avoids intermediate SG table manipulation and operates directly on BIOs.

Thanks

[1] https://lore.kernel.org/all/169772852492.5232.17148564580779995849.stgit@klimt.1015granger.net

Chaitanya Kulkarni (2):
block: add dma_link_range() based API
nvme-pci: use blk_rq_dma_map() for NVMe SGL

Leon Romanovsky (14):
mm/hmm: let users to tag specific PFNs
dma-mapping: provide an interface to allocate IOVA
dma-mapping: provide callbacks to link/unlink pages to specific IOVA iommu/dma: Provide an interface to allow preallocate IOVA iommu/dma: Prepare map/unmap page functions to receive IOVA iommu/dma: Implement link/unlink page callbacks
RDMA/umem: Preallocate and cache IOVA for UMEM ODP RDMA/umem: Store ODP access mask information in PFN RDMA/core: Separate DMA mapping to caching IOVA and page linkage RDMA/umem: Prevent UMEM ODP creation with SWIOTLB vfio/mlx5: Explicitly use number of pages instead of allocated length vfio/mlx5: Rewrite create mkey flow to allow better code reuse vfio/mlx5: Explicitly store page list
vfio/mlx5: Convert vfio to use DMA link API

 Documentation/core-api/dma-attributes.rst |   7 +
 block/blk-merge.c                         | 156 ++++++++++++++
 drivers/infiniband/core/umem_odp.c        | 219 +++++++------------
 drivers/infiniband/hw/mlx5/mlx5_ib.h      |   1 +
 drivers/infiniband/hw/mlx5/odp.c          |  59 +++--
 drivers/iommu/dma-iommu.c                 | 129 ++++++++---
 drivers/nvme/host/pci.c                   | 220 +++++--------------
 drivers/vfio/pci/mlx5/cmd.c               | 252 ++++++++++++----------
 drivers/vfio/pci/mlx5/cmd.h               |  22 +-
 drivers/vfio/pci/mlx5/main.c              | 136 +++++-------
 include/linux/blk-mq.h                    |   9 +
 include/linux/dma-map-ops.h               |  13 ++
 include/linux/dma-mapping.h               |  39 ++++
 include/linux/hmm.h                       |   3 +
 include/rdma/ib_umem_odp.h                |  22 +-
 include/rdma/ib_verbs.h                   |  54 +++++
 kernel/dma/debug.h                        |   2 +
 kernel/dma/direct.h                       |   7 +-
 kernel/dma/mapping.c                      |  91 ++++++++
 mm/hmm.c                                  |  34 +--
 20 files changed, 870 insertions(+), 605 deletions(-)
Signature · 1 line
2.44.0