Skip to content

fix softlockups in stage2_apply_range()

Krister Johansen kvm stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: arm64: Work out supported block level at compile timearch/arm64/include/asm/kvm_pgtable.h+13 -50 replies
2/2KVM: arm64: Limit stage2_apply_range() batch size to largest blockarch/arm64/include/asm/stage2_pgtable.h arch/arm64/kvm/mmu.c+8 -210 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc Zyngier
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 5.15.y v2 0/2] fix softlockups in stage2_apply_range()

Hi Stable Team,
In 5.15, unmapping large kvm vms on arm64 can generate softlockups. My team has been hitting this when tearing down VMs > 100Gb in size.

Oliver fixed this with the attached patches. They've been in mainline since 6.1.

I tested on 5.15.150 with these patches applied. When they're present, both the dirty_log_perf_test detailed in the second patch, and kvm_page_table_test no longer generate softlockups when unmapping VMs with large memory configurations.

Would you please consider these patches for inclusion in an upcoming 5.15 release?

Change in v2: I ran format-patch without the --from option which incorrectly generated the first series without leaving Oliver in place as the author. The v2 should retain the correct authorship. Apologies for the mistake.

-K

Oliver Upton (2):
KVM: arm64: Work out supported block level at compile time
KVM: arm64: Limit stage2_apply_range() batch size to largest block

 arch/arm64/include/asm/kvm_pgtable.h    | 18 +++++++++++++-----
 arch/arm64/include/asm/stage2_pgtable.h | 20 --------------------
 arch/arm64/kvm/mmu.c                    |  9 ++++++++-
 3 files changed, 21 insertions(+), 26 deletions(-)
Signature · 1 line
2.25.1