Skip to content

fuzz: build fuzzers by default on Linux

Josh Steadmon git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 12 repliesSuperseded

Changes in v2 from the cover letter

* Rebased onto master
* Fixed compiler mismatch issue when we override CC but not CXX
* Consolidated some of the fuzzer Makefile definitions in one location

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ci: also define CXX environment variable.github/workflows/main.yml+12 -02 replies
2/2fuzz: link fuzz programs with `make all` on LinuxMakefile ci/run-build-and-minimal-fuzzers.sh config.mak.uname+32 -221 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJeff King
1/2
2/2Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] fuzz: build fuzzers by default on Linux

Please note: this has been rebased onto the current 'master' [436d4e5b14 (The seventeenth batch, 2024-04-10)] in order to resolve a conflict with the recently merged bt/fuzz-config-parse series.

Increase our protection against fuzzer bit-rot by making sure we can link the fuzz test executables on Linux. Patch 1 is a small CI config improvement to fix compiler feature detection. Patch 2 is the Makefile / config.mak.uname change to add the executables to make all on Linux.

Changes in V2:
* Rebased onto master
* Fixed compiler mismatch issue when we override CC but not CXX
* Consolidated some of the fuzzer Makefile definitions in one location

Josh Steadmon (2):
ci: also define CXX environment variable
fuzz: link fuzz programs with make all on Linux

 .github/workflows/main.yml          | 12 +++++++
 Makefile                            | 51 +++++++++++++++++------------
 ci/run-build-and-minimal-fuzzers.sh |  2 +-
 config.mak.uname                    |  1 +
 4 files changed, 44 insertions(+), 22 deletions(-)

Range-diff against v1:
1: 75f98cbf98 ! 1: e55b691272 ci: also define CXX environment variable
@@ Commit message
'detect-compiler' script only looks at CC. Fix the issue by always setting CXX to match CC in our CI config.

- We only plan on building fuzzers on Linux, so none of the other CI
- configs need a similar adjustment.
+ We only plan on building fuzzers on Linux with the next patch, so for
+ now, only adjust configuration for the Linux CI jobs.

2:  eef15e3d3d < -:  ---------- fuzz: link fuzz programs with `make all` on Linux
-:  ---------- > 2:  8846a7766a fuzz: link fuzz programs with `make all` on Linux

base-commit: 436d4e5b14df49870a897f64fe92c0ddc7017e4c

Signature · 1 line
2.44.0.683.g7961c838ac-goog