Skip to content

drm: fix .get_modes() return values

Jani Nikula dri-devel intel-gfx stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/probe-helper: warn about negative .get_modes()drivers/gpu/drm/drm_probe_helper.c include/drm/drm_modeset_helper_vtables.h+9 -10 replies
2/8drm/panel: do not return negative error codes from drm_panel_get_modes()drivers/gpu/drm/drm_panel.c+11 -62 replies
3/8drm/exynos: do not return negative values from .get_modes()drivers/gpu/drm/exynos/exynos_drm_vidi.c drivers/gpu/drm/exynos/exynos_hdmi.c+4 -40 replies
4/8drm/bridge: lt8912b: do not return negative values from .get_modes()drivers/gpu/drm/bridge/lontium-lt8912b.c+7 -90 replies
5/8drm/imx/ipuv3: do not return negative values from .get_modes()drivers/gpu/drm/imx/ipuv3/parallel-display.c+2 -21 reply
6/8drm/vc4: hdmi: do not return negative values from .get_modes()drivers/gpu/drm/vc4/vc4_hdmi.c+1 -11 reply
7/8drm/bridge: lt9611uxc: use int for holding number of modesdrivers/gpu/drm/bridge/lontium-lt9611uxc.c+1 -12 replies
8/8drm/exynos: simplify the return value handling in exynos_dp_get_modes()drivers/gpu/drm/exynos/exynos_dp.c+3 -40 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime RipardPhilipp ZabelJessica ZhangThomas ZimmermannNeil ArmstrongDmitry Baryshkov
SeriesA-b
1/8
2/8R-b R-b
3/8
4/8
5/8A-b
6/8A-b
7/8R-b R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] drm: fix .get_modes() return values

The drm_connector_helper_funcs .get_modes() hooks are not supposed to return negative error codes. Some do, but they're not checked, and could lead to mysterious errors. Fix this all over the place.

BR,
Jani.

Jani Nikula (8):
drm/probe-helper: warn about negative .get_modes() drm/panel: do not return negative error codes from
drm_panel_get_modes()
drm/exynos: do not return negative values from .get_modes() drm/bridge: lt8912b: do not return negative values from .get_modes() drm/imx/ipuv3: do not return negative values from .get_modes() drm/vc4: hdmi: do not return negative values from .get_modes() drm/bridge: lt9611uxc: use int for holding number of modes drm/exynos: simplify the return value handling in
exynos_dp_get_modes()

 drivers/gpu/drm/bridge/lontium-lt8912b.c     | 16 +++++++---------
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c   |  2 +-
 drivers/gpu/drm/drm_panel.c                  | 17 +++++++++++------
 drivers/gpu/drm/drm_probe_helper.c           |  7 +++++++
 drivers/gpu/drm/exynos/exynos_dp.c           |  7 +++----
 drivers/gpu/drm/exynos/exynos_drm_vidi.c     |  4 ++--
 drivers/gpu/drm/exynos/exynos_hdmi.c         |  4 ++--
 drivers/gpu/drm/imx/ipuv3/parallel-display.c |  4 ++--
 drivers/gpu/drm/vc4/vc4_hdmi.c               |  2 +-
 include/drm/drm_modeset_helper_vtables.h     |  3 ++-
 10 files changed, 38 insertions(+), 28 deletions(-)
Signature · 1 line
2.39.2