Skip to content

perf: Clean up common uncore boilerplate

Robin Murphy linux-arm-kernel linux-perf-users lkml llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10perf/alibaba_uncore_drw: Use correct CPU affinitydrivers/perf/alibaba_uncore_drw_pmu.c+2 -100 replies
2/10perf: Add capability for common event supportinclude/linux/perf_event.h kernel/events/core.c+6 -02 replies
3/10drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTSdrivers/perf/alibaba_uncore_drw_pmu.c drivers/perf/amlogic/meson_ddr_pmu_core.c drivers/perf/arm-cci.c +20 more+47 -1070 replies
4/10perf: Rename PERF_PMU_CAP_NO_INTERRUPTarch/arc/kernel/perf_event.c arch/csky/kernel/perf_event.c arch/powerpc/perf/8xx-pmu.c +16 more+23 -230 replies
5/10drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistentlydrivers/perf/alibaba_uncore_drw_pmu.c drivers/perf/amlogic/meson_ddr_pmu_core.c drivers/perf/arm-cci.c +18 more+36 -832 replies
6/10drivers/perf: Clean up redundant per-task checksdrivers/perf/alibaba_uncore_drw_pmu.c drivers/perf/amlogic/meson_ddr_pmu_core.c drivers/perf/arm-cci.c +18 more+0 -1390 replies
7/10perf: Define common uncore capabilitiesinclude/linux/perf_event.h+3 -02 replies
8/10drivers/perf: Use common uncore capabilitiesdrivers/perf/alibaba_uncore_drw_pmu.c drivers/perf/amlogic/meson_ddr_pmu_core.c drivers/perf/arm-cci.c +19 more+22 -660 replies
9/10x86: Use common uncore PMU capabilitiesarch/x86/events/amd/iommu.c arch/x86/events/amd/power.c arch/x86/events/amd/uncore.c +5 more+14 -900 replies
10/10ARM: Use common uncore PMU capabilitiesarch/arm/mach-imx/mmdc.c arch/arm/mm/cache-l2x0-pmu.c+2 -261 reply

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJames ClarkShawn Guo
SeriesR-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] perf: Clean up common uncore boilerplate

Hi all,

Since this came up yet again recently, and it's an idea which has been nagging me for years, I decided it was time to see how hard it really would be to start shaving this yak. And it turns out to be refreshingly simple - the core code has quietly become capable of doing most of what we want, the one new functional addition is trivial (patch #2), and the resulting largely-mechanical cleanup seems a pretty nice win.

This series is focused on drivers/perf/ as that's where most mess is concentrated, but figured I'd include the arch/ patches as well since they might be reasonable to land with the core changes, at least for x86 (FWIW I did also look at the powerpc drivers but they scared me and I ran away; sorry). The remaining stragglers elsewhere around the tree I'd come back to as a follow-up.

(And yes, I appreciate it's mid-merge-window already, but since I do have a tree-wide rename proposed here, may as well give the discussion a chance for a head start before -rc1...)

Thanks,
Robin.

Robin Murphy (10):
perf/alibaba_uncore_drw: Use correct CPU affinity
perf: Add capability for common event support drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTS
perf: Rename PERF_PMU_CAP_NO_INTERRUPT drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistently drivers/perf: Clean up redundant per-task checks
perf: Define common uncore capabilities drivers/perf: Use common uncore capabilities
x86: Use common uncore PMU capabilities
ARM: Use common uncore PMU capabilities

 arch/arc/kernel/perf_event.c              |  2 +-
 arch/arm/mach-imx/mmdc.c                  | 16 +-------------
 arch/arm/mm/cache-l2x0-pmu.c              | 12 +---------
 arch/csky/kernel/perf_event.c             |  2 +-
 arch/powerpc/perf/8xx-pmu.c               |  2 +-
 arch/powerpc/perf/hv-24x7.c               |  2 +-
 arch/powerpc/perf/hv-gpci.c               |  2 +-
 arch/powerpc/platforms/pseries/papr_scm.c |  2 +-
 arch/s390/kernel/perf_cpum_cf.c           |  2 +-
 arch/sh/kernel/perf_event.c               |  2 +-
 arch/x86/events/amd/iommu.c               | 17 +-------------
 arch/x86/events/amd/power.c               | 10 +--------
 arch/x86/events/amd/uncore.c              | 12 +++-------
 arch/x86/events/core.c                    |  2 +-
 arch/x86/events/intel/cstate.c            | 16 +++-----------
 arch/x86/events/intel/uncore.c            | 11 +--------
 arch/x86/events/intel/uncore_snb.c        | 20 +++--------------
 arch/x86/events/msr.c                     |  9 +-------
 arch/x86/events/rapl.c                    |  9 +-------
 drivers/fpga/dfl-fme-perf.c               |  2 +-
 drivers/perf/alibaba_uncore_drw_pmu.c     | 27 +++--------------------
 drivers/perf/amlogic/meson_ddr_pmu_core.c | 11 +--------
 drivers/perf/arm-cci.c                    | 15 +------------
 drivers/perf/arm-ccn.c                    | 20 +----------------
 drivers/perf/arm-cmn.c                    | 10 +--------
 drivers/perf/arm_cspmu/arm_cspmu.c        | 27 ++---------------------
 drivers/perf/arm_dmc620_pmu.c             | 18 +--------------
 drivers/perf/arm_dsu_pmu.c                | 22 +-----------------
 drivers/perf/arm_pmu_platform.c           |  2 +-
 drivers/perf/arm_smmuv3_pmu.c             | 15 +------------
 drivers/perf/arm_spe_pmu.c                |  7 ++----
 drivers/perf/cxl_pmu.c                    |  8 +------
 drivers/perf/dwc_pcie_pmu.c               | 13 +----------
 drivers/perf/fsl_imx8_ddr_perf.c          | 13 +----------
 drivers/perf/fsl_imx9_ddr_perf.c          | 13 +----------
 drivers/perf/hisilicon/hisi_pcie_pmu.c    | 10 +--------
 drivers/perf/hisilicon/hisi_uncore_pmu.c  | 20 +----------------
 drivers/perf/hisilicon/hns3_pmu.c         |  9 +-------
 drivers/perf/marvell_cn10k_ddr_pmu.c      | 15 +------------
 drivers/perf/marvell_cn10k_tad_pmu.c      |  6 +----
 drivers/perf/qcom_l2_pmu.c                | 21 ++----------------
 drivers/perf/qcom_l3_pmu.c                | 21 +-----------------
 drivers/perf/riscv_pmu_sbi.c              |  2 +-
 drivers/perf/thunderx2_pmu.c              | 17 +-------------
 drivers/perf/xgene_pmu.c                  | 16 +-------------
 include/linux/perf_event.h                |  6 ++++-
 kernel/events/core.c                      |  7 +++++-
 47 files changed, 67 insertions(+), 456 deletions(-)
Signature · 1 line
2.39.2.101.g768bb238c484.dirty