Skip to content

fstests: various RAID56 related fixes for btrfs

Josef Bacik fstests linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Reworked the golden output of btrfs/197 and btrfs/198 to handle running some of the RAID profiles.
- Added a new way to require RAID profiles in the tests, updated all the different tests.
- Changed btrfs/197, btrfs/198, and btrfs/297 to skip any RAID profiles that aren't supported by our RAID profile settings.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fstests: change btrfs/197 and btrfs/198 golden outputtests/btrfs/197 tests/btrfs/197.out tests/btrfs/198 +1 more+12 -521 reply
2/3fstests: change how we test for supported raid configscommon/btrfs tests/btrfs/125 tests/btrfs/148 +2 more+29 -91 reply
3/3fstests: update tests to skip unsupported raid profile typestests/btrfs/197 tests/btrfs/198 tests/btrfs/297+26 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAnand Jain
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] fstests: various RAID56 related fixes for btrfs

v1: https://lore.kernel.org/linux-btrfs/[email protected]/

v1->v2:
- Reworked the golden output of btrfs/197 and btrfs/198 to handle running some of the RAID profiles.
- Added a new way to require RAID profiles in the tests, updated all the different tests.
- Changed btrfs/197, btrfs/198, and btrfs/297 to skip any RAID profiles that aren't supported by our RAID profile settings.

--- Original email ---
Hello,

While trying to get CI setup internally I noticed that we were sometimes failing raid56 tests even though I had specified BTRFS_PROFILE_CONFIGS without raid56 in them.

This is because tests where we require raid56 to work only check to see if it's enabled by the kernel, not to check and see if we're configured to use it with our profile configs.

One test needed to be updated to skip any configurations that weren't in our profile configs, and then a few tests didn't use the

_require_btrfs_fs_feature raid56

check in the top of their test. This series fixes everything up and honors the user settings which makes my internal CI runs clean where we don't want to test raid56. Thanks,

Josef

Josef Bacik (3):
fstests: change btrfs/197 and btrfs/198 golden output
fstests: change how we test for supported raid configs
fstests: update tests to skip unsupported raid profile types

 common/btrfs        | 29 ++++++++++++++++++++++++-----
 tests/btrfs/125     |  2 +-
 tests/btrfs/148     |  3 ++-
 tests/btrfs/157     |  2 +-
 tests/btrfs/158     |  2 +-
 tests/btrfs/197     | 17 +++++++++++++----
 tests/btrfs/197.out | 25 +------------------------
 tests/btrfs/198     | 17 +++++++++++++----
 tests/btrfs/198.out | 25 +------------------------
 tests/btrfs/297     | 10 ++++++++++
 10 files changed, 67 insertions(+), 65 deletions(-)
Signature · 1 line
2.43.0