btrfs: zoned: fix EXTENT_BUFFER_ZONED_ZEROOUT handling
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest2 patches 3 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: zoned: do not flag ZEROOUT on non-dirty extent buffferfs/ | +1 | 0 replies | |
| 2/2 | btrfs: zoned: add ASSERT and WARN for EXTENT_BUFFER_ZONED_ZEROOUT handlingfs/ fs/ | +9 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Johannes Thumshirn | David Sterba |
|---|---|---|
| Series | R-b | |
| 1/2 | ||
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] btrfs: zoned: fix EXTENT_BUFFER_ZONED_ZEROOUT handling
Btrfs clears the content of an extent buffer marked as EXTENT_BUFFER_ZONED_ZEROOUT before the bio submission. This mechanism is introduced to prevent a write hole of an extent buffer, which is once allocated, marked dirty, but turns out unnecessary and cleaned up within one transaction operation.
Currently, btrfs_clear_buffer_dirty() marks the extent buffer as EXTENT_BUFFER_ZONED_ZEROOUT, and skip the enteri function. If this call happens while the buffer is under IO (with the WRITEBACK flag set, without the DIRTY flag), we can add the ZEROOUT flag and clear the buffer's content just before a bio submission. As a result, 1) it can lead to adding faulty delayed reference item which leads to a FS corrupted (EUCLEAN) error, and
2) it writes out cleared tree node on disk
Fix them by skipping a non-dirty extent buffer. Also, the second patch adds ASSERT and WARN to catch invalid EXTENT_BUFFER_ZONED_ZEROOUT state.
Naohiro Aota (2):
btrfs: zoned: do not flag ZEROOUT on non-dirty extent bufffer
btrfs: zoned: add ASSERT and WARN for EXTENT_BUFFER_ZONED_ZEROOUT
handling
fs/btrfs/extent-tree.c | 8 ++++++++ fs/btrfs/extent_io.c | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-)
Signature · 6 lines
Changes: - Change the fix to address the root cause. v1: https://lore.kernel.org/linux-btrfs/3f4f2a0ff1a6c818050434288925bdcf3cd719e5.1709124777.git.naohiro.aota@wdc.com/ -- 2.44.0