Skip to content

setsockopt per subflow: BPF

Geliang Tang mptcp 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest posting 2/24 patches 3 repliesIn review
  2. v8 posting 2/24 patches 2 repliesSuperseded
  3. v9 posting 1/28 patches 7 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v8 posting 1/29 patches4 repliesSuperseded
v7 posting 2/25 patches1 replySuperseded
v7 posting 1/29 patches5 repliesSuperseded
v6 posting 2/29 patches7 repliesSuperseded
v6 posting 1/28 patches2 repliesSuperseded
v510 patches2 repliesSuperseded
v411 patches1 replySuperseded
v38 patches1 replySuperseded
v215 patches0 repliesSuperseded
v111 patches1 replySuperseded

Changes in v9 from the cover letter

- validate the return value of snprintf in patch 2 as Mat suggested.
- patch 2 depends on "selftests/bpf: Add RUN_MPTCP_TEST macro", so this series could be merged in this order:
1 selftests/bpf: Add mptcp subflow example
2 selftests/bpf: Add RUN_MPTCP_TEST macro
3 selftests/bpf: Add mptcp subflow subtest
4 selftests/bpf: Handle SIGINT when creating netns

Patches in v9 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4selftests/bpf: Add mptcp subflow exampletools/testing/selftests/bpf/progs/mptcp_subflow.c+70 -00 replies
2/4selftests/bpf: Add mptcp subflow subtesttools/testing/selftests/bpf/prog_tests/mptcp.c+112 -60 replies
3/4selftests/bpf: Handle SIGINT when creating netnstools/testing/selftests/bpf/prog_tests/mptcp.c+7 -00 replies
4/4Squash to "selftests/bpf: Add bpf scheduler test"tools/testing/selftests/bpf/prog_tests/mptcp.c+6 -120 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH mptcp-next v9 0/4] setsockopt per subflow: BPF

From: Geliang Tang <[email protected]>

v9:
- validate the return value of snprintf in patch 2 as Mat suggested.
- patch 2 depends on "selftests/bpf: Add RUN_MPTCP_TEST macro", so this series could be merged in this order:
1 selftests/bpf: Add mptcp subflow example
2 selftests/bpf: Add RUN_MPTCP_TEST macro
3 selftests/bpf: Add mptcp subflow subtest
4 selftests/bpf: Handle SIGINT when creating netns

v8:
- update the git metadata to add Nicolas as the git "Author" and add a "Co-authored-by" tag with my name in patch 1 as Mat suggested in v7.
- use send_byte in patch 2 instead of send_recv_data, to make this series independent of the commit "selftests/bpf: Export send_recv_data helper", which is in bpf-next, but not in mptcp_net-next at this moment.

v7:
- address Mat's comments in v6 (thanks): drop MPTCP_BASE_TEST and rebased.
- depends on:
"refactor mptcp bpf tests" v7
"export send_byte and send_recv_data" v2

v6:
- Deponds on "[bpf-next] export send_byte and send_recv_data" series.

v5:
- #1-#7 Address #76: add new macros MPTCP_BASE_TEST and RUN_MPTCP_TEST.
- #8-#14 add MPTCP_SCHED_TEST macro.

v4:
- #1-#5 Address #76: add a new macro RUN_MPTCP_TEST.
- #6-#11 Cleanups: add send_data_and_verify and SCHED_TEST.

v3:
- deal with EAGAIN.
- add _ss_search helper.

v2:
- fix checkpatch warnings.
- cleanups.

Geliang Tang (3):
selftests/bpf: Add mptcp subflow subtest selftests/bpf: Handle SIGINT when creating netns Squash to "selftests/bpf: Add bpf scheduler test"

Nicolas Rybowski (1):
selftests/bpf: Add mptcp subflow example

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 143 +++++++++++++++---
 .../selftests/bpf/progs/mptcp_subflow.c       |  70 +++++++++
 2 files changed, 195 insertions(+), 18 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_subflow.c
Signature · 1 line
2.40.1