Skip to content

Make support for multi-value configuration options more consistent

Dragan Simic git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3diff: support additional whitespace in diff.{dirstat,wsErrorHighlight}builtin/gc.c diff.c notes.c +7 more+46 -230 replies
2/3t4015: whitespace in diff.wsErrorHighlight and --ws-error-highlightt/t4015-diff-whitespace.sh+34 -20 replies
3/3t4047: whitespace in diff.dirstat and --dirstatt/t4047-diff-dirstat.sh+30 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Make support for multi-value configuration options more consistent

This series adds support for optional placing of additional whitespace characters around the commas in the multi-value, comma-separated values for the "diff.dirstat" and "diff.wsErrorHighlight" configuration options, and the "--dirstat" and "--ws-error-highlight" command-line options.

This makes the way multi-(sub)value configuration options can be specified more consistent, because exactly the same additional whitespace characters are already allowed for some of the configuration options. It may also make the configuration files more readable to some users.

Dragan Simic (3):
diff: support additional whitespace in diff.{dirstat,wsErrorHighlight}
t4015: whitespace in diff.wsErrorHighlight and --ws-error-highlight
t4047: whitespace in diff.dirstat and --dirstat

 builtin/gc.c                |  4 ++--
 diff.c                      | 14 ++++++++++----
 notes.c                     |  2 +-
 refs/packed-backend.c       |  2 +-
 string-list.c               | 27 +++++++++++++++++++++------
 string-list.h               | 10 ++++++----
 t/helper/test-hashmap.c     |  2 +-
 t/helper/test-json-writer.c |  2 +-
 t/helper/test-oidmap.c      |  2 +-
 t/helper/test-string-list.c |  4 ++--
 t/t4015-diff-whitespace.sh  | 36 ++++++++++++++++++++++++++++++++++--
 t/t4047-diff-dirstat.sh     | 33 ++++++++++++++++++++++++++++++---
 12 files changed, 110 insertions(+), 28 deletions(-)