Skip to content

mlxsw: Preparations for improving performance

Petr Machata netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 15 repliesApplied 15/15

Patches in v1 All 15 applied

#Subject and filesSizeRepliesApplied
1/15mlxsw: pci: Move mlxsw_pci_eq_{init, fini}()drivers/net/ethernet/mellanox/mlxsw/pci.c+36 -361 replyApplied
2/15mlxsw: pci: Move mlxsw_pci_cq_{init, fini}()drivers/net/ethernet/mellanox/mlxsw/pci.c+43 -431 replyApplied
3/15mlxsw: pci: Do not setup tasklet from operationdrivers/net/ethernet/mellanox/mlxsw/pci.c+2 -61 replyApplied
4/15mlxsw: pci: Arm CQ doorbell regardless of number of completionsdrivers/net/ethernet/mellanox/mlxsw/pci.c+2 -21 replyApplied
5/15mlxsw: pci: Remove unused countersdrivers/net/ethernet/mellanox/mlxsw/pci.c+18 -311 replyApplied
6/15mlxsw: pci: Make style changes in mlxsw_pci_eq_tasklet()drivers/net/ethernet/mellanox/mlxsw/pci.c+13 -101 replyApplied
7/15mlxsw: pci: Poll command interface for each cmd_exec()drivers/net/ethernet/mellanox/mlxsw/pci.c+17 -311 replyApplied
8/15mlxsw: pci: Rename MLXSW_PCI_EQS_COUNTdrivers/net/ethernet/mellanox/mlxsw/pci.c drivers/net/ethernet/mellanox/mlxsw/pci_hw.h+3 -31 replyApplied
9/15mlxsw: pci: Use only one event queuedrivers/net/ethernet/mellanox/mlxsw/pci.c drivers/net/ethernet/mellanox/mlxsw/pci_hw.h+16 -401 replyApplied
10/15mlxsw: pci: Remove unused wait queuedrivers/net/ethernet/mellanox/mlxsw/pci.c+4 -81 replyApplied
11/15mlxsw: pci: Make style change in mlxsw_pci_cq_tasklet()drivers/net/ethernet/mellanox/mlxsw/pci.c+2 -21 replyApplied
12/15mlxsw: pci: Break mlxsw_pci_cq_tasklet() into tasklets per queue typedrivers/net/ethernet/mellanox/mlxsw/pci.c+74 -121 replyApplied
13/15mlxsw: pci: Remove mlxsw_pci_sdq_count()drivers/net/ethernet/mellanox/mlxsw/pci.c+7 -121 replyApplied
14/15mlxsw: pci: Remove mlxsw_pci_cq_count()drivers/net/ethernet/mellanox/mlxsw/pci.c+3 -151 replyApplied
15/15mlxsw: pci: Store DQ pointer as part of CQ structuredrivers/net/ethernet/mellanox/mlxsw/pci.c+28 -131 replyApplied

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchIdo SchimmelSimon Horman
1/15R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b
10/15R-b R-b
11/15R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b R-b
15/15R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/15] mlxsw: Preparations for improving performance

Amit Cohen writes:

mlxsw driver will use NAPI for event processing in a next patch set. Some additional improvements will be added later. This patch set prepares the code for NAPI usage and refactor some relevant areas. See more details in commit messages.

Patch Set overview:
Patches #1-#2 are preparations for patch #3
Patch #3 setups tasklets as part of queue initializtion Patch #4 removes handling of unlikely scenario
Patch #5 removes unused counters
Patch #6 makes style change in mlxsw_pci_eq_tasklet()
Patch #7-#10 poll command interface instead of EQ0 usage Patches #11-#12 make style change and break the function mlxsw_pci_cq_tasklet()
Patches #13-#14 remove functions which can be replaced by a stored value Patch #15 improves accessing to descriptor queue instance

Amit Cohen (15):
mlxsw: pci: Move mlxsw_pci_eq_{init, fini}()
mlxsw: pci: Move mlxsw_pci_cq_{init, fini}()
mlxsw: pci: Do not setup tasklet from operation
mlxsw: pci: Arm CQ doorbell regardless of number of completions
mlxsw: pci: Remove unused counters
mlxsw: pci: Make style changes in mlxsw_pci_eq_tasklet()
mlxsw: pci: Poll command interface for each cmd_exec()
mlxsw: pci: Rename MLXSW_PCI_EQS_COUNT
mlxsw: pci: Use only one event queue
mlxsw: pci: Remove unused wait queue
mlxsw: pci: Make style change in mlxsw_pci_cq_tasklet()
mlxsw: pci: Break mlxsw_pci_cq_tasklet() into tasklets per queue type
mlxsw: pci: Remove mlxsw_pci_sdq_count()
mlxsw: pci: Remove mlxsw_pci_cq_count()
mlxsw: pci: Store DQ pointer as part of CQ structure

 drivers/net/ethernet/mellanox/mlxsw/pci.c    | 492 ++++++++++---------
 drivers/net/ethernet/mellanox/mlxsw/pci_hw.h |   4 +-
 2 files changed, 250 insertions(+), 246 deletions(-)
Signature · 1 line
2.43.0