Skip to content

fix icmp error source address over xfrm tunnel

Antony Antony linux-kselftest netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 7 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v11 patch 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfrm: fix source address in icmp error generation from IPsec gatewaynet/ipv4/icmp.c+0 -10 replies
2/2selftests/net: add ICMP unreachable over IPsec tunneltools/testing/selftests/net/Makefile tools/testing/selftests/net/xfrm_state.sh+625 -04 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchTobias Brunner
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] fix icmp error source address over xfrm tunnel

Hi,
This fix, originally intended for XFRM/IPsec, has been recommended by Steffen Klassert to submit to the net tree.

The patch addresses a minor issue related to the IPv4 source address of ICMP error messages, which originated from an old 2011 commit:

415b3334a21a ("icmp: Fix regression in nexthop resolution during replies.")

The omission of a "Fixes" tag in the following commit is deliberate to prevent potential test failures and subsequent regression issues that may arise from backporting this patch all stable kerenels. This is a minor fix, anot not security fix.
With a seleftest I am submitting this to net-next tree.

v2->v3 : fix testscript. The IFS, space, got mangled. v1->v2 : add kernel selftest script

Antony Antony (2):
xfrm: fix source address in icmp error generation from IPsec gateway selftests/net: add ICMP unreachable over IPsec tunnel

 net/ipv4/icmp.c                           |   1 -
 tools/testing/selftests/net/Makefile      |   1 +
 tools/testing/selftests/net/xfrm_state.sh | 624 ++++++++++++++++++++++
 3 files changed, 625 insertions(+), 1 deletion(-)
 create mode 100755 tools/testing/selftests/net/xfrm_state.sh

--
2.30.2