Skip to content

t: exercise Git/JGit reftable compatibility

Patrick Steinhardt git 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest13 patches 7 repliesIn review
  2. v313 patches 2 repliesSuperseded
  3. v212 patches 21 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches12 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ci: rename "runs_on_pool" to "distro".github/workflows/main.yml ci/install-dependencies.sh ci/lib.sh+4 -40 replies
2/13ci: expose distro name in dockerized GitHub jobs.github/workflows/main.yml+4 -00 replies
3/13ci: skip sudo when we are already rootci/install-dependencies.sh+11 -00 replies
4/13ci: drop duplicate package installation for "linux-gcc-default"ci/install-dependencies.sh+8 -90 replies
5/13ci: convert "install-dependencies.sh" to use "/bin/sh"ci/install-dependencies.sh+12 -170 replies
6/13ci: merge custom PATH directoriesci/install-dependencies.sh ci/lib.sh+10 -150 replies
7/13ci: fix setup of custom path for GitLab CI.gitlab-ci.yml ci/lib.sh+3 -10 replies
8/13ci: merge scripts which install dependencies.github/workflows/main.yml .gitlab-ci.yml ci/install-dependencies.sh +1 more+31 -530 replies
9/13ci: make Perforce binaries executable for all usersci/install-dependencies.sh+1 -10 replies
10/13ci: install JGit dependencyci/install-dependencies.sh+14 -10 replies
11/13t06xx: always execute backend-specific testst/t0600-reffiles-backend.sh t/t0601-reffiles-pack-refs.sh t/t0610-reftable-basics.sh+8 -180 replies
12/13t0610: fix non-portable variable assignmentt/t0610-reftable-basics.sh+3 -30 replies
13/13t0612: add tests to exercise Git/JGit reftable compatibilityt/t0612-reftable-jgit-compatibility.sh+132 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/13] t: exercise Git/JGit reftable compatibility

Hi,

here's the (hopefully last) version of my patch series that introduces Git/JGit compatibility tests for the reftable format. Only a single commit changed, where I fixed two typos and added a missing signoff.

Thanks!

Patrick

Patrick Steinhardt (13):
ci: rename "runs_on_pool" to "distro"
ci: expose distro name in dockerized GitHub jobs
ci: skip sudo when we are already root
ci: drop duplicate package installation for "linux-gcc-default"
ci: convert "install-dependencies.sh" to use "/bin/sh"
ci: merge custom PATH directories
ci: fix setup of custom path for GitLab CI
ci: merge scripts which install dependencies
ci: make Perforce binaries executable for all users
ci: install JGit dependency
t06xx: always execute backend-specific tests
t0610: fix non-portable variable assignment
t0612: add tests to exercise Git/JGit reftable compatibility

 .github/workflows/main.yml             |   8 +-
 .gitlab-ci.yml                         |   6 +-
 ci/install-dependencies.sh             | 101 +++++++++++++------
 ci/install-docker-dependencies.sh      |  46 ---------
 ci/lib.sh                              |  14 +--
 t/t0600-reffiles-backend.sh            |   8 +-
 t/t0601-reffiles-pack-refs.sh          |   9 +-
 t/t0610-reftable-basics.sh             |  15 ++-
 t/t0612-reftable-jgit-compatibility.sh | 132 +++++++++++++++++++++++++
 9 files changed, 229 insertions(+), 110 deletions(-)
 delete mode 100755 ci/install-docker-dependencies.sh
 create mode 100755 t/t0612-reftable-jgit-compatibility.sh

Range-diff against v3:

 1:  46502bbe22 =  1:  99b0b60359 ci: rename "runs_on_pool" to "distro"
 2:  d076ed9857 =  2:  e1d4e1320d ci: expose distro name in dockerized GitHub jobs
 3:  cc0c29052f =  3:  44a0e07600 ci: skip sudo when we are already root
 4:  803f5020e0 =  4:  8e58ce38d9 ci: drop duplicate package installation for "linux-gcc-default"
 5:  d2745e9438 =  5:  b8f56a5e67 ci: convert "install-dependencies.sh" to use "/bin/sh"
 6:  61f108d954 =  6:  ce4f0c766c ci: merge custom PATH directories
 7:  ef61b578da !  7:  9fc462b578 ci: fix setup of custom path for GitLab CI

@@ Commit message
root user, but runs tests as a separate, unprivileged user. As their respective home directories are different, we will end up using two different custom path directories. Consequently, the unprivileged user
- will not be able eto find the binaries that were setu up as root user.
+ will not be able to find the binaries that were set up as root user.

Fix this issue by allowing CI to override the custom path, which allows GitLab to set up a constant value that isn't derived from "$HOME".

+ Signed-off-by: Patrick Steinhardt <[email protected]>
+
## .gitlab-ci.yml ##
@@ .gitlab-ci.yml: workflow:

 8:  7748f87f8c =  8:  e7a17d57e7 ci: merge scripts which install dependencies
 9:  f7399382f2 =  9:  720d5a4682 ci: make Perforce binaries executable for all users
10:  b835ff8b78 = 10:  77f6d6ecaa ci: install JGit dependency
11:  7136c8b6c2 = 11:  acf0c28550 t06xx: always execute backend-specific tests
12:  cf4ee9c427 = 12:  a9b71e8eea t0610: fix non-portable variable assignment
13:  a9cd20eebc = 13:  218c694d2e t0612: add tests to exercise Git/JGit reftable compatibility

base-commit: 436d4e5b14df49870a897f64fe92c0ddc7017e4c

Signature · 1 line
2.44.GIT