Skip to content

t0610: fix umask tests

Patrick Steinhardt git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2t0610: make `--shared=` tests reusablet/t0610-reftable-basics.sh+30 -270 replies
2/2t0610: execute git-pack-refs(1) with specified umaskt/t0610-reftable-basics.sh+14 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] t0610: fix umask tests

Hi,

these patches address the issue reported by Junio where running t0610 with an umask of 0027 breaks some tests. The root cause of this is quite
simple: we executed git-pack-refs(1) outside of the shell that had the modified umask, and thus we ran tests with the umask of the host shell by accident.

The series fixes this issue and extends the tests to exercise more umasks than just 002 and 022, which would have caught the issue earlier.

Patrick

Patrick Steinhardt (2):
t0610: make --shared= tests reusable
t0610: execute git-pack-refs(1) with specified umask

 t/t0610-reftable-basics.sh | 67 ++++++++++++++++++++++----------------
 1 file changed, 39 insertions(+), 28 deletions(-)
Signature · 1 line
2.44.GIT