Skip to content

use start_server and connect_to helpers

Geliang Tang bpf linux-kselftest 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 6 repliesIn review
  2. v114 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- update patch 6 only, fix errors reported by CI.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14selftests/bpf: Add start_server_addr helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+6 -01 reply
2/14selftests/bpf: Use start_server_addr in cls_redirecttools/testing/selftests/bpf/prog_tests/cls_redirect.c+2 -180 replies
3/14selftests/bpf: Use connect_to_addr in cls_redirecttools/testing/selftests/bpf/prog_tests/cls_redirect.c+1 -170 replies
4/14selftests/bpf: Use start_server_addr in sk_assigntools/testing/selftests/bpf/prog_tests/sk_assign.c+2 -250 replies
5/14selftests/bpf: Use connect_to_addr in sk_assigntools/testing/selftests/bpf/prog_tests/sk_assign.c+1 -251 reply
6/14selftests/bpf: Use log_err in network_helperstools/testing/selftests/bpf/network_helpers.c+14 -50 replies
7/14selftests/bpf: Use start_server_addr in test_sock_addrtools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/test_sock_addr.c+7 -350 replies
8/14selftests/bpf: Use connect_to_addr in test_sock_addrtools/testing/selftests/bpf/test_sock_addr.c+2 -340 replies
9/14selftests/bpf: Add function pointer for __start_servertools/testing/selftests/bpf/network_helpers.c+13 -91 reply
10/14selftests/bpf: Add start_server_setsockopt helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+8 -00 replies
11/14selftests/bpf: Use start_server_setsockopt in sockopt_inherittools/testing/selftests/bpf/prog_tests/sockopt_inherit.c+14 -192 replies
12/14selftests/bpf: Use connect_to_fd in sockopt_inherittools/testing/selftests/bpf/prog_tests/sockopt_inherit.c+1 -300 replies
13/14selftests/bpf: Use start_server_* in test_tcp_check_syncookietools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c+12 -390 replies
14/14selftests/bpf: Use connect_to_addr in test_tcp_check_syncookietools/testing/selftests/bpf/test_tcp_check_syncookie_user.c+1 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 00/14] use start_server and connect_to helpers

From: Geliang Tang <[email protected]>

v2:
- update patch 6 only, fix errors reported by CI.

This patchset uses public helpers start_server_* and connect_to_* defined in network_helpers.c to drop duplicate code.

Geliang Tang (14):
selftests/bpf: Add start_server_addr helper selftests/bpf: Use start_server_addr in cls_redirect selftests/bpf: Use connect_to_addr in cls_redirect selftests/bpf: Use start_server_addr in sk_assign selftests/bpf: Use connect_to_addr in sk_assign selftests/bpf: Use log_err in network_helpers selftests/bpf: Use start_server_addr in test_sock_addr selftests/bpf: Use connect_to_addr in test_sock_addr selftests/bpf: Add function pointer for __start_server selftests/bpf: Add start_server_setsockopt helper selftests/bpf: Use start_server_setsockopt in sockopt_inherit selftests/bpf: Use connect_to_fd in sockopt_inherit selftests/bpf: Use start_server_* in test_tcp_check_syncookie selftests/bpf: Use connect_to_addr in test_tcp_check_syncookie

 tools/testing/selftests/bpf/Makefile          |  4 +-
 tools/testing/selftests/bpf/network_helpers.c | 50 ++++++++----
 tools/testing/selftests/bpf/network_helpers.h |  4 +
 .../selftests/bpf/prog_tests/cls_redirect.c   | 38 +---------
 .../selftests/bpf/prog_tests/sk_assign.c      | 53 +------------
 .../bpf/prog_tests/sockopt_inherit.c          | 64 ++++------------
 tools/testing/selftests/bpf/test_sock_addr.c  | 74 ++----------------
 .../bpf/test_tcp_check_syncookie_user.c       | 76 +++----------------
 8 files changed, 83 insertions(+), 280 deletions(-)
Signature · 1 line
2.40.1