fstests: btrfs: migrate to use `_btrfs` for snapshotting
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest2 patches 2 repliesIn review
Changes in v2 from the cover letter
- Rename _run_btrfs_util_prog to _btrfs and use it as our recommended way for simple btrfs command
- Use the new _btrfs for snapshotting to fix the golden output mismatch
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | fstests: btrfs: rename _run_btrfs_util_prog to _btrfscommon/ tests/ tests/ +71 more | +339 | 1 reply | |
| 2/2 | fstests: btrfs: use _btrfs for 'subvolume snapshot' commandtests/ tests/ tests/ +41 more | +37 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Anand Jain |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] fstests: btrfs: migrate to use `_btrfs` for snapshotting
[CHANGELOG]
v2:
- Rename _run_btrfs_util_prog to _btrfs and use it as our recommended way for simple btrfs command
- Use the new _btrfs for snapshotting to fix the golden output mismatch
After more dicussion, it turns out that we'd better go the old _run_btrfs_util_prog for most simple btrfs commands.
And to make it more closer to the regular "btrfs" command, just rename it to _btrfs, and put it at the beginning of common/btrfs file, and recommending it to be utilized.
Then fix the golden output by utilizing that new helper. Now there is no "Create a " line in btrfs golden output anymore.
In the future, we will migrate to use _btrfs for subvolume creation and deletion too.
Qu Wenruo (2):
fstests: btrfs: rename _run_btrfs_util_prog to _btrfs
fstests: btrfs: use _btrfs for 'subvolume snapshot' command
common/btrfs | 15 ++++++++------- tests/btrfs/001 | 2 +- tests/btrfs/001.out | 1 - tests/btrfs/004 | 2 +- tests/btrfs/007 | 6 +++--- tests/btrfs/011 | 10 +++++----- tests/btrfs/017 | 6 +++--- tests/btrfs/022 | 6 +++--- tests/btrfs/025 | 20 ++++++++++---------- tests/btrfs/028 | 4 ++-- tests/btrfs/030 | 12 ++++++------ tests/btrfs/034 | 12 ++++++------ tests/btrfs/038 | 20 ++++++++++---------- tests/btrfs/039 | 12 ++++++------ tests/btrfs/040 | 12 ++++++------ tests/btrfs/041 | 2 +- tests/btrfs/042 | 10 +++++----- tests/btrfs/043 | 12 ++++++------ tests/btrfs/044 | 12 ++++++------ tests/btrfs/045 | 12 ++++++------ tests/btrfs/046 | 14 +++++++------- tests/btrfs/048 | 16 ++++++++-------- tests/btrfs/050 | 6 +++--- tests/btrfs/051 | 6 +++--- tests/btrfs/052 | 2 +- tests/btrfs/053 | 12 ++++++------ tests/btrfs/054 | 18 +++++++++--------- tests/btrfs/057 | 6 +++--- tests/btrfs/058 | 4 ++-- tests/btrfs/077 | 12 ++++++------ tests/btrfs/080 | 2 +- tests/btrfs/083 | 12 ++++++------ tests/btrfs/084 | 12 ++++++------ tests/btrfs/085 | 4 ++-- tests/btrfs/087 | 12 ++++++------ tests/btrfs/090 | 2 +- tests/btrfs/091 | 8 ++++---- tests/btrfs/092 | 12 ++++++------ tests/btrfs/094 | 12 ++++++------ tests/btrfs/097 | 12 ++++++------ tests/btrfs/099 | 4 ++-- tests/btrfs/100 | 6 +++--- tests/btrfs/101 | 6 +++--- tests/btrfs/104 | 10 +++++----- tests/btrfs/105 | 14 +++++++------- tests/btrfs/108 | 6 +++--- tests/btrfs/109 | 6 +++--- tests/btrfs/110 | 16 ++++++++-------- tests/btrfs/111 | 20 ++++++++++---------- tests/btrfs/117 | 18 +++++++++--------- tests/btrfs/118 | 8 ++++---- tests/btrfs/119 | 6 +++--- tests/btrfs/120 | 4 ++-- tests/btrfs/121 | 2 +- tests/btrfs/122 | 10 +++++----- tests/btrfs/123 | 2 +- tests/btrfs/124 | 10 +++++----- tests/btrfs/125 | 18 +++++++++--------- tests/btrfs/126 | 4 ++-- tests/btrfs/127 | 12 ++++++------ tests/btrfs/128 | 12 ++++++------ tests/btrfs/129 | 12 ++++++------ tests/btrfs/130 | 2 +- tests/btrfs/139 | 6 +++--- tests/btrfs/152 | 14 ++++++-------- tests/btrfs/152.out | 2 -- tests/btrfs/153 | 4 ++-- tests/btrfs/161 | 4 ++-- tests/btrfs/162 | 6 +++--- tests/btrfs/163 | 12 ++++++------ tests/btrfs/164 | 12 ++++++------ tests/btrfs/166 | 2 +- tests/btrfs/167 | 2 +- tests/btrfs/168 | 6 ++---- tests/btrfs/168.out | 2 -- tests/btrfs/169 | 6 ++---- tests/btrfs/169.out | 2 -- tests/btrfs/170 | 3 +-- tests/btrfs/170.out | 1 - tests/btrfs/187 | 6 ++---- tests/btrfs/187.out | 2 -- tests/btrfs/188 | 6 ++---- tests/btrfs/188.out | 2 -- tests/btrfs/189 | 6 ++---- tests/btrfs/189.out | 2 -- tests/btrfs/191 | 6 ++---- tests/btrfs/191.out | 2 -- tests/btrfs/200 | 6 ++---- tests/btrfs/200.out | 2 -- tests/btrfs/202 | 3 +-- tests/btrfs/202.out | 1 - tests/btrfs/203 | 6 ++---- tests/btrfs/203.out | 2 -- tests/btrfs/218 | 2 +- tests/btrfs/226 | 3 +-- tests/btrfs/226.out | 1 - tests/btrfs/272 | 14 +++++++------- tests/btrfs/273 | 6 +++--- tests/btrfs/276 | 2 +- tests/btrfs/276.out | 1 - tests/btrfs/278 | 14 +++++++------- tests/btrfs/280 | 2 +- tests/btrfs/280.out | 1 - tests/btrfs/281 | 3 +-- tests/btrfs/281.out | 1 - tests/btrfs/283 | 3 +-- tests/btrfs/283.out | 1 - tests/btrfs/287 | 6 ++---- tests/btrfs/287.out | 2 -- tests/btrfs/293 | 4 ++-- tests/btrfs/293.out | 2 -- tests/btrfs/300 | 2 +- tests/btrfs/300.out | 1 - tests/btrfs/302 | 3 +-- tests/btrfs/302.out | 1 - tests/btrfs/314 | 3 +-- tests/btrfs/314.out | 2 -- tests/btrfs/320 | 16 ++++++++-------- 118 files changed, 376 insertions(+), 436 deletions(-)
Signature · 1 line
2.44.0