Skip to content

use network helpers, part 1

Geliang Tang bpf linux-kselftest 3 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 0 repliesApplied 6/6
  2. v414 patches 3 repliesSuperseded
  3. v39 patches 0 repliesSuperseded

Changes in v5 from the cover letter

- address Martin's comments for v4. (thanks)
- drop start_server_addr_opts, add opts as a argument of start_server_addr.
- add opts argument for connect_to_addr too.
- move some patches out of this set, stay with start_server_addr() and connect_to_addr() only in it.

Patches in v5 All 6 applied

#Subject and filesSizeRepliesApplied
1/6selftests/bpf: Add start_server_addr helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+14 -20 repliesApplied
2/6selftests/bpf: Use start_server_addr in cls_redirecttools/testing/selftests/bpf/prog_tests/cls_redirect.c+2 -180 repliesApplied
3/6selftests/bpf: Use start_server_addr in sk_assigntools/testing/selftests/bpf/prog_tests/sk_assign.c+4 -250 repliesApplied
4/6selftests/bpf: Update arguments of connect_to_addrtools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/sock_addr.c+15 -70 repliesApplied
5/6selftests/bpf: Use connect_to_addr in cls_redirecttools/testing/selftests/bpf/prog_tests/cls_redirect.c+1 -170 repliesApplied
6/6selftests/bpf: Use connect_to_addr in sk_assigntools/testing/selftests/bpf/prog_tests/sk_assign.c+1 -250 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH bpf-next v5 0/6] use network helpers, part 1

From: Geliang Tang <[email protected]>

v5:
- address Martin's comments for v4. (thanks)
- drop start_server_addr_opts, add opts as a argument of start_server_addr.
- add opts argument for connect_to_addr too.
- move some patches out of this set, stay with start_server_addr() and connect_to_addr() only in it.

v4:
- add more patches using make_sockaddr and get_socket_local_port helpers.

v3:
- address comments of Martin and Eduard in v2. (thanks)
- move "int type" to the first argument of start_server_addr and connect_to_addr.
- add start_server_addr_opts.
- using "sockaddr_storage" instead of "sockaddr".
- move start_server_setsockopt patches out of this series.

v2:
- update patch 6 only, fix errors reported by CI.

This patchset uses public helpers start_server_* and connect_to_* defined in network_helpers.c to drop duplicate code.

Geliang Tang (6):
selftests/bpf: Add start_server_addr helper selftests/bpf: Use start_server_addr in cls_redirect selftests/bpf: Use start_server_addr in sk_assign selftests/bpf: Update arguments of connect_to_addr selftests/bpf: Use connect_to_addr in cls_redirect selftests/bpf: Use connect_to_addr in sk_assign

 tools/testing/selftests/bpf/network_helpers.c | 27 +++++++--
 tools/testing/selftests/bpf/network_helpers.h |  5 +-
 .../selftests/bpf/prog_tests/cls_redirect.c   | 38 +------------
 .../selftests/bpf/prog_tests/sk_assign.c      | 55 ++-----------------
 .../selftests/bpf/prog_tests/sock_addr.c      |  6 +-
 5 files changed, 37 insertions(+), 94 deletions(-)
Signature · 1 line
2.40.1