mmc: sdhci-of-dwcmshc: Add Sophgo SG2042 support
Status from this message: Applied to sg2042/for-next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 13 repliesApplied
- v58 patches 12 repliesSuperseded
- v44 patches 9 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 4 patches | 12 replies | Superseded | |
| v2 | 1 patch | 6 replies | Superseded | |
| v1 | 1 patch | 3 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | mmc: sdhci-of-dwcmshc: add common bulk optional clocks supportdrivers/ | +48 | 6 replies | |
| 2/8 | mmc: sdhci-of-dwcmshc: move two rk35xx functionsdrivers/ | +45 | 1 reply | |
| 3/8 | mmc: sdhci-of-dwcmshc: factor out code for th1520_init()drivers/ | +30 | 1 reply | |
| 4/8 | mmc: sdhci-of-dwcmshc: factor out code into dwcmshc_rk35xx_initdrivers/ | +16 | 1 reply | |
| 5/8 | mmc: sdhci-of-dwcmshc: add dwcmshc_pltfm_datadrivers/ | +48 | 1 reply | |
| 6/8 | dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo SG2042 supportDocumentation/ | +43 | 0 replies | |
| 7/8 | mmc: sdhci-of-dwcmshc: Add support for Sophgo SG2042drivers/ | +118 | 1 reply | |
| 8/8 | riscv: sophgo: dts: add mmc controllers for SG2042 SoCarch/ arch/ | +45 | 0 replies |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Drew Fustini | Inochi Amaoto | Conor Dooley | Adrian Hunter |
|---|---|---|---|---|
| 1/8 | T-b | T-b | A-b | |
| 2/8 | T-b | T-b | A-b | |
| 3/8 | R-b T-b | T-b | A-b | |
| 4/8 | T-b | T-b | A-b | |
| 5/8 | T-b | T-b | A-b | |
| 6/8 | R-b | |||
| 7/8 | A-b | |||
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v6 0/8] mmc: sdhci-of-dwcmshc: Add Sophgo SG2042 support
From: Chen Wang <[email protected]>
This patchset is composed of two parts:
- one is the improvement of the sdhci-of-dwcmshc framework,
- the other is the support for sg2042 based on the improvement of the framework.
The reason for merging the two parts into one patchset is mainly to facilitate review, especially to facilitate viewing why we need to improve the framework and what benefits it will bring to us.
When I tried to add a new soc(SG2042) to sdhci-of-dwcmshc, I found that the existing driver code could be optimized to facilitate expansion for the new soc. Patch 1 ~ Patch 5 is for this.
Patch 6 ~ 7 are adding support for the mmc controller for Sophgo SG2042. Adding corresponding new compatible strings, and implement custom callbacks for SG2042 based on new framework.
Patch 8 is the change for DTS.
By the way, although I believe this patch only optimizes the framework of the code and does not change the specific logic, simple verification is certainly better. Since I don't have rk35xx/th1520 related hardware, it would be greatly appreciated if someone could help verify it.
---
Changes in v6:
The patch series is based on latest 'next' branch of [mmc-git].
- Some minor improvements based on Adrian's review suggestions.
- Added Reviewed-by and Tested-by signatures from Conor/Drew/Inochi.
Changes in v5:
The patch series is based on latest 'next' branch of [mmc-git]. You can simply review or test the patches at the link [5].
- Based on Adrian's suggestion, split the first part of the patch into 5.
- Updated bindings and DTS as per suggestion from Krzysztof, Jisheng and Conor.
Changes in v4:
The patch series is based on latest 'next' branch of [mmc-git]. You can simply review or test the patches at the link [4].
Improved the dirvier code as per comments from Adrian Hunter, drop moving position and renaming for some helper functions.
Put the sg2042 support as part of this series, improve the bindings and code as per comments from last review.
Changes in v3:
The patch series is based on latest 'next' branch of [mmc-git]. You can simply review or test the patches at the link [3].
Improved the dirvier code as per comments from Adrian Hunter. Define new structure for dwcmshc platform data/ops. In addition, I organized the code and classified the helper functions.
Since the file changes were relatively large (though the functional logic did not change much), I split the original patch into four for the convenience of review.
Changes in v2:
Rebased on latest 'next' branch of [mmc-git]. You can simply review or test the patches at the link [2].
Changes in v1:
The patch series is based on v6.9-rc1. You can simply review or test the patches at the link [1].
---
Chen Wang (8):
mmc: sdhci-of-dwcmshc: add common bulk optional clocks support
mmc: sdhci-of-dwcmshc: move two rk35xx functions
mmc: sdhci-of-dwcmshc: factor out code for th1520_init()
mmc: sdhci-of-dwcmshc: factor out code into dwcmshc_rk35xx_init
mmc: sdhci-of-dwcmshc: add dwcmshc_pltfm_data
dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo SG2042 support
mmc: sdhci-of-dwcmshc: Add support for Sophgo SG2042
riscv: sophgo: dts: add mmc controllers for SG2042 SoC
.../bindings/mmc/snps,dwcmshc-sdhci.yaml | 60 ++- .../boot/dts/sophgo/sg2042-milkv-pioneer.dts | 17 + arch/riscv/boot/dts/sophgo/sg2042.dtsi | 28 ++ drivers/mmc/host/sdhci-of-dwcmshc.c | 451 ++++++++++++------ 4 files changed, 383 insertions(+), 173 deletions(-)
base-commit: 538076ce6b8dfe5e8e8d9d250298030f165d8457
Signature · 1 line
2.34.1