mlxsw: Fixes
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 1 replyApplied 3/3
- v13 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- Patch #2:
- Make mlxsw_env_max_module_eeprom_len_query() void
Patches in v2 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mlxsw: core: Unregister EMAD trap using FORWARD actiondrivers/ | +1 | 0 replies | Applied |
| 2/3 | mlxsw: core_env: Fix driver initialization with old firmwaredrivers/ | +6 | 1 reply | Applied |
| 3/3 | mlxsw: pci: Fix driver initialization with old firmwaredrivers/ | +4 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Petr Machata | Simon Horman | Kalesh AP |
|---|---|---|---|
| 1/3 | R-b | R-b | |
| 2/3 | R-b | R-b | |
| 3/3 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net v2 0/3] mlxsw: Fixes
This patchset fixes the following issues:
- During driver de-initialization the driver unregisters the EMAD response trap by setting its action to DISCARD. However the manual only permits TRAP and FORWARD, and future firmware versions will enforce this.
In patch #1, suppress the error message by aligning the driver to the manual and use a FORWARD (NOP) action when unregistering the trap.
- The driver queries the Management Capabilities Mask (MCAM) register during initialization to understand if certain features are supported.
However, not all firmware versions support this register, leading to the driver failing to load.
Patches #2 and #3 fix this issue by treating an error in the register query as an indication that the feature is not supported.
v2:
- Patch #2:
- Make mlxsw_env_max_module_eeprom_len_query() void
Ido Schimmel (3):
mlxsw: core: Unregister EMAD trap using FORWARD action
mlxsw: core_env: Fix driver initialization with old firmware
mlxsw: pci: Fix driver initialization with old firmware
drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +- .../net/ethernet/mellanox/mlxsw/core_env.c | 20 ++++++------------- drivers/net/ethernet/mellanox/mlxsw/pci.c | 10 ++++------ 3 files changed, 11 insertions(+), 21 deletions(-)
Signature · 1 line
2.43.0