Skip to content

format-patch: fix an option coexistence bug and add new --resend option

Dragan Simic git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 46 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4format-patch docs: avoid use of parentheses to improve readabilityDocumentation/git-format-patch.txt+2 -20 replies
2/4format-patch: fix a bug in option exclusivity and add a test to t4014builtin/log.c t/t4014-format-patch.sh+8 -112 replies
3/4format-patch: new --resend option for adding "RESEND" to patch subjectsDocumentation/git-format-patch.txt builtin/log.c+14 -228 replies
4/4t4014: add tests to cover --resend option and its exclusivityt/t4014-format-patch.sh+37 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] format-patch: fix an option coexistence bug and add new --resend option

This series fixes a bug that allows --rfc and -k options to be specified together when running "git format-patch". This bug was introduced about eight months ago, but it has remained undetected, presumably because of lacking test coverage. While fixing this bug, also add a test that covers this mutual exclusion, for future coverage.

This series also adds --resend as the new option for "git format-patch" that adds "RESEND" as a (sub)suffix to the patch subject prefix, which eventually produces "[PATCH RESEND]" as the default patch subject prefix. This subject prefix is commonly used on mailing lists to denote patches resent after they had attracted no attention for a while.

Dragan Simic (4):
format-patch docs: avoid use of parentheses to improve readability
format-patch: fix a bug in option exclusivity and add a test to t4014
format-patch: new --resend option for adding "RESEND" to patch
subjects
t4014: add tests to cover --resend option and its exclusivity

 Documentation/git-format-patch.txt |  9 +++++--
 builtin/log.c                      | 16 +++++++++---
 t/t4014-format-patch.sh            | 41 ++++++++++++++++++++++++++++++
 3 files changed, 61 insertions(+), 5 deletions(-)