btrfs: qgroup: stale qgroups related impromvents
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 0 repliesNew
- v32 patches 4 repliesSuperseded
- v22 patches 25 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- Slight code style changes
Move one nested if into a single line one.
- Make can_delete_qgroup() return int to indicate error during tree search
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: slightly loose the requirement for qgroup removalfs/ | +84 | 0 replies | |
| 2/2 | btrfs: automatically remove the subvolume qgroupfs/ fs/ fs/ | +48 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Boris Burkov |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] btrfs: qgroup: stale qgroups related impromvents
[CHANGELOG]
v4:
- Slight code style changes
Move one nested if into a single line one.
- Make can_delete_qgroup() return int to indicate error during tree search
v3:
- Do not allow dropping non-zero qgroups for squota
Due to the design of squota, a fully dropped subvolume can still have non-zero qgroups, as in the extent tree the delta is still using the original owner (the dropped subvolume).
So we can not drop any non-zero squota qgroups
- Slight change on the can_delete_qgroup() condition To co-operate with above change.
v2:
- Do more sanity checks before deleting a qgroup
- Make squota to handle auto deleted qgroup more gracefully Unfortunately the behavior change would affect btrfs/301, as the fully deleted subvolume would make the test case to cause bash grammar error (since the qgroup is gone with the subvolume).
Cc Boris for extra comments on squota compatibility and future btrfs/311 updates ideas.
We have two problems in recent qgroup code:
- One can not delete a fully removed qgroup if the drop hits drop_subtree_threshold
As hitting drop_subtree_threshold would mark qgroup inconsistent and skip all accounting, this would leave qgroup number untouched (thus non-zero), and btrfs refuses to delete qgroup with non-zero rfer/excl numbers.
This would be addressed by the first patch, allowing qgroup deletion as long as it doesn't have any child nor a corresponding subvolume.
- Deleted snapshot would leave a stale qgroup
This is a long existing problem.
Although previous pushes all failed, just let me try it again.
The idea is commit current transaction if needed (full accounting mode and qgroup numbers are consistent), then try to remove the subvolume qgroup after it is fully dropped.
For full qgroup mode, no matter if qgroup is inconsistent, we will auto remove the dropped 0 level qgroup.
(If consistent, the qgroup numbers should all be 0, and a safe
removal. If inconsistent, we still remove the qgroup, leaving higher level qgroup incorrect, but since it's already inconsistent, we need a rescan anyway).
For squota mode, we only do the auto reap if the qgroup numbers are already 0.
Otherwise the qgroup numbers would be needed for future accounting.
The behavior change would only affect btrfs/301, which still expects the dropped subvolume would still leave its qgroup untouched. But that can be easily fixed by explicitly echoing "0" for dropped subvolume.
Qu Wenruo (2):
btrfs: slightly loose the requirement for qgroup removal
btrfs: automatically remove the subvolume qgroup
fs/btrfs/extent-tree.c | 8 +++ fs/btrfs/qgroup.c | 129 ++++++++++++++++++++++++++++++++++++++--- fs/btrfs/qgroup.h | 2 + 3 files changed, 132 insertions(+), 7 deletions(-)
Signature · 1 line
2.45.1