Skip to content

drm: Restore helper usability

Geert Uytterhoeven dri-devel linux-kbuild linux-renesas-soc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2"drivers/gpu/drm/bridge/analogix/Kconfig drivers/gpu/drm/rockchip/Kconfig+2 -20 replies
2/11Revert "drm/display: Select DRM_KMS_HELPER for DP helpers"drivers/gpu/drm/display/Kconfig+0 -10 replies
3/11Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable"drivers/gpu/drm/bridge/synopsys/Kconfig+1 -10 replies
4/11Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies"drivers/gpu/drm/exynos/Kconfig drivers/gpu/drm/rockchip/Kconfig+2 -20 replies
5/11Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on"drivers/gpu/drm/amd/amdgpu/Kconfig drivers/gpu/drm/bridge/synopsys/Kconfig drivers/gpu/drm/display/Kconfig +5 more+7 -80 replies
6/11Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on"drivers/gpu/drm/amd/amdgpu/Kconfig drivers/gpu/drm/bridge/Kconfig drivers/gpu/drm/bridge/analogix/Kconfig +4 more+6 -70 replies
7/11Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on"drivers/gpu/drm/Kconfig drivers/gpu/drm/amd/amdgpu/Kconfig drivers/gpu/drm/bridge/Kconfig +14 more+26 -270 replies
8/11Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on"drivers/gpu/drm/bridge/Kconfig drivers/gpu/drm/bridge/analogix/Kconfig drivers/gpu/drm/display/Kconfig +4 more+9 -100 replies
9/11Revert "drm: Switch DRM_DISPLAY_HELPER to depends on"drivers/gpu/drm/Kconfig drivers/gpu/drm/amd/amdgpu/Kconfig drivers/gpu/drm/bridge/Kconfig +16 more+45 -590 replies
10/11Revert "drm: Make drivers depends on DRM_DW_HDMI"drivers/gpu/drm/bridge/imx/Kconfig drivers/gpu/drm/imx/ipuv3/Kconfig drivers/gpu/drm/ingenic/Kconfig +4 more+9 -100 replies
11/11Revert "drm/display: Make all helpers visible and switch to depends on"drivers/gpu/drm/display/Kconfig+12 -140 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArnd Bergmann
SeriesA-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] drm: Restore helper usability

Hi all,

As discussed on IRC with Maxime and Arnd, this series reverts the conversion of select to depends for various DRM helpers in series "[PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on"[1], and various fixes for it. This conversion introduced a big usability issue when configuring a kernel and enabling DRM drivers that use DRM helper code: as drivers now depend on helpers, the user needs to know which helpers to enable, before the driver he is interested even becomes visible. The user should not need to know that, and drivers should select the helpers they need.

Hence revert back to what we had before, where drivers selected the helpers (and any of their dependencies, if they can be met) they need. In general, when a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met, which may mean adding dependencies to the source symbol.

Thanks for applying!

[1] https://lore.kernel.org/r/[email protected]/

Geert Uytterhoeven (11):
Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2" Revert "drm/display: Select DRM_KMS_HELPER for DP helpers" Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable" Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies" Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on" Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on" Revert "drm: Switch DRM_DISPLAY_HELPER to depends on" Revert "drm: Make drivers depends on DRM_DW_HDMI"
Revert "drm/display: Make all helpers visible and switch to depends

    on"
 drivers/gpu/drm/Kconfig                 |  8 +++----
 drivers/gpu/drm/amd/amdgpu/Kconfig      | 12 ++++------
 drivers/gpu/drm/bridge/Kconfig          | 28 +++++++++++-----------
 drivers/gpu/drm/bridge/analogix/Kconfig | 18 +++++++-------
 drivers/gpu/drm/bridge/cadence/Kconfig  |  8 +++----
 drivers/gpu/drm/bridge/imx/Kconfig      |  4 ++--
 drivers/gpu/drm/bridge/synopsys/Kconfig |  6 ++---
 drivers/gpu/drm/display/Kconfig         | 32 ++++++++++---------------
 drivers/gpu/drm/exynos/Kconfig          |  4 ++--
 drivers/gpu/drm/i915/Kconfig            |  8 +++----
 drivers/gpu/drm/imx/ipuv3/Kconfig       |  5 ++--
 drivers/gpu/drm/ingenic/Kconfig         |  2 +-
 drivers/gpu/drm/mediatek/Kconfig        |  6 ++---
 drivers/gpu/drm/meson/Kconfig           |  2 +-
 drivers/gpu/drm/msm/Kconfig             |  8 +++----
 drivers/gpu/drm/nouveau/Kconfig         | 10 ++++----
 drivers/gpu/drm/panel/Kconfig           | 32 ++++++++++++-------------
 drivers/gpu/drm/radeon/Kconfig          |  8 +++----
 drivers/gpu/drm/renesas/rcar-du/Kconfig |  2 +-
 drivers/gpu/drm/rockchip/Kconfig        | 10 ++++----
 drivers/gpu/drm/sun4i/Kconfig           |  2 +-
 drivers/gpu/drm/tegra/Kconfig           |  8 +++----
 drivers/gpu/drm/vc4/Kconfig             | 10 ++++----
 drivers/gpu/drm/xe/Kconfig              | 13 ++++------
 drivers/gpu/drm/xlnx/Kconfig            |  8 +++----
 25 files changed, 116 insertions(+), 138 deletions(-)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds