Skip to content

virtio_snd_set_config: Fix #2296

Manos Pitsidianakis qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio-snd: add virtio_snd_is_config_valid()hw/audio/virtio-snd.c+29 -181 reply
2/4virtio-snd: factor card setup out of realize funchw/audio/virtio-snd.c+41 -311 reply
3/4virtio-snd: factor card removal out of unrealize()hw/audio/virtio-snd.c+14 -62 replies
4/4virtio_snd_set_config: validate and re-setup cardhw/audio/virtio-snd.c+21 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/4] virtio_snd_set_config: Fix #2296

Changing the number of streams via virtio_snd_set_config() did not re-configure the audio card, leaving it in an invalid state.

Reported in https://gitlab.com/qemu-project/qemu/-/issues/2296

Manos Pitsidianakis (4):
virtio-snd: add virtio_snd_is_config_valid()
virtio-snd: factor card setup out of realize func
virtio-snd: factor card removal out of unrealize()
virtio_snd_set_config: validate and re-setup card

 hw/audio/virtio-snd.c | 174 +++++++++++++++++++++++++-----------------
 1 file changed, 105 insertions(+), 69 deletions(-)

base-commit: 62dbe54c24dbf77051bafe1039c31ddc8f37602d

Signature · 1 line
γαῖα πυρί μιχθήτω