Skip to content

Update IXGBE base driver

Anatoly Burakov dpdk-dev 3 versions – Applied

Status from this message: Applied to dpdk-next-net-intel with some small cleanups:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest30 patches 1 replyApplied
  2. v227 patches 2 repliesSuperseded
  3. v122 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Split out big patch with definitions into a separate patch
- Split out the "miscellaneous" patch into smaller patches and scattered its contents across different patches where appropriate
- Rolled in DPDK-unrelated changes into "miscellaneous" patch
- Removed unused function definition in final patch

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/30net/ixgbe/base: revert remove default advertising for x550 2.5G/5Gdrivers/net/ixgbe/base/ixgbe_phy.c+4 -00 replies
2/30net/ixgbe/base: fix wrong 5G link speed reported on VFdrivers/net/ixgbe/base/ixgbe_vf.c+3 -30 replies
3/30net/ixgbe/base: fix PHY ID for X550drivers/net/ixgbe/base/ixgbe_phy.c drivers/net/ixgbe/base/ixgbe_type.h+2 -20 replies
4/30net/ixgbe/base: rename message type macrosdrivers/net/ixgbe/base/ixgbe_mbx.h drivers/net/ixgbe/base/ixgbe_vf.c drivers/net/ixgbe/ixgbe_ethdev.c +1 more+35 -300 replies
5/30net/ixgbe/base: correct registers names to match datasheetdrivers/net/ixgbe/base/ixgbe_mbx.c drivers/net/ixgbe/base/ixgbe_mbx.h drivers/net/ixgbe/base/ixgbe_type.h+25 -250 replies
6/30net/ixgbe/base: introduce new mailbox APIdrivers/net/ixgbe/base/ixgbe_82599.c drivers/net/ixgbe/base/ixgbe_hv_vf.c drivers/net/ixgbe/base/ixgbe_mbx.c +6 more+702 -2940 replies
7/30net/ixgbe/base: increase DCB BW calculation for MTU from 4088 to 9128drivers/net/ixgbe/base/ixgbe_dcb.h+2 -20 replies
8/30net/ixgbe/base: improve function commentsdrivers/net/ixgbe/base/ixgbe_82599.c drivers/net/ixgbe/base/ixgbe_api.c drivers/net/ixgbe/base/ixgbe_common.c +4 more+21 -200 replies
9/30net/ixgbe/base: add fw_rst_cnt field to ixgbe_hw structdrivers/net/ixgbe/base/ixgbe_type.h+1 -00 replies
10/30net/ixgbe/base: replace HIC with direct register accessdrivers/net/ixgbe/base/ixgbe_x550.c drivers/net/ixgbe/base/ixgbe_x550.h+2 -780 replies
11/30net/ixgbe/base: added link state handlingdrivers/net/ixgbe/base/ixgbe_mbx.h drivers/net/ixgbe/base/ixgbe_type.h drivers/net/ixgbe/base/ixgbe_vf.c +1 more+32 -00 replies
12/30net/ixgbe/base: handle -Wimplicit-fallthroughdrivers/net/ixgbe/base/ixgbe_82599.c drivers/net/ixgbe/base/ixgbe_common.c drivers/net/ixgbe/base/ixgbe_x550.c+18 -80 replies
13/30net/ixgbe/base: remove non-inclusive languagedrivers/net/ixgbe/base/ixgbe_common.c drivers/net/ixgbe/base/ixgbe_common.h drivers/net/ixgbe/base/ixgbe_type.h +1 more+24 -240 replies
14/30net/ixgbe/base: filter out spurious link up indicationdrivers/net/ixgbe/base/ixgbe_common.c+17 -20 replies
15/30net/ixgbe/base: remove circular header dependencydrivers/net/ixgbe/base/ixgbe_mbx.h+1 -10 replies
16/30net/ixgbe/base: add missing QV definesdrivers/net/ixgbe/base/ixgbe_type.h+5 -00 replies
17/30net/ixgbe/base: improve SWFW semaphore acquisitiondrivers/net/ixgbe/base/ixgbe_x550.c+22 -190 replies
18/30net/ixgbe/base: prevent untrusted loop bounddrivers/net/ixgbe/base/ixgbe_common.c+1 -10 replies
19/30net/ixgbe/base: remove prototypes of unimplemented functionsdrivers/net/ixgbe/base/ixgbe_api.h drivers/net/ixgbe/base/ixgbe_x550.h+0 -30 replies
20/30net/ixgbe/base: add definitions for E610drivers/net/ixgbe/base/ixgbe_osdep.c drivers/net/ixgbe/base/ixgbe_osdep.h drivers/net/ixgbe/base/ixgbe_type.h +2 more+1804 -40 replies
21/30net/ixgbe/base: add support for E610 Admin Command Interfacedrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h drivers/net/ixgbe/base/ixgbe_osdep.h +2 more+664 -00 replies
22/30net/ixgbe/base: add support for E610 device capabilities detectiondrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h drivers/net/ixgbe/base/ixgbe_osdep.h +1 more+735 -00 replies
23/30net/ixgbe/base: add link management support for E610 devicedrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h drivers/net/ixgbe/base/ixgbe_type_e610.h+1474 -00 replies
24/30net/ixgbe/base: add support for NVM handling in E610 devicedrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h+341 -00 replies
25/30net/ixgbe/base: enable E610 device supportdrivers/net/ixgbe/base/ixgbe_82599.c drivers/net/ixgbe/base/ixgbe_api.c drivers/net/ixgbe/base/ixgbe_api.h +8 more+1302 -230 replies
26/30net/ixgbe/base: add i2c and GPIO read/write APIdrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h+168 -00 replies
27/30net/ixgbe/base: add NVM init and populatedrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h+247 -00 replies
28/30net/ixgbe/base: alternate structure operations supportdrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h+141 -00 replies
29/30net/ixgbe/base: support more NVM-related operationsdrivers/net/ixgbe/base/ixgbe_e610.c drivers/net/ixgbe/base/ixgbe_e610.h drivers/net/ixgbe/base/ixgbe_type_e610.h+485 -00 replies
30/30net/ixgbe/base: add various miscellaneous featuresdoc/guides/rel_notes/release_24_07.rst drivers/net/ixgbe/base/README drivers/net/ixgbe/base/ixgbe_api.c +2 more+216 -40 replies

Reviews trailers per patch

14 of 30 patches have a Reviewed-by or Acked-by.

PatchSkajewski, PiotrXMarek MicalKirsher, Jeffrey TMichael, AliceTyl, RadoslawXMrozowicz, SlawomirXZalfresso-jundzillo, MarekXPietruszewski, PiotrGalazka, KrzysztofEryk RybakRacicot, FrancisJan Sokolowski
1/30R-b R-b R-b R-b
2/30R-b R-b R-b
3/30R-b R-b
4/30R-b T-b R-b T-b R-b R-b
5/30R-b T-b R-b T-b R-b R-b
6/30T-b R-b T-b R-b
7/30R-b T-b R-b R-b
8/30R-b R-b R-b
9/30R-b R-b R-b
10/30R-b R-b R-b R-b
11/30R-b R-b R-b
12/30R-b
13/30R-b
14/30R-b
15/30
16/30
17/30
18/30
19/30
20/30
21/30
22/30
23/30
24/30
25/30
26/30
27/30
28/30
29/30
30/30

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 12 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/30] Update IXGBE base driver

This patchset updates IXGBE base driver to latest shared code snapshot, fixing a few issues as well as adding support for new hardware.

v3:
- Split out big patch with definitions into a separate patch
- Split out the "miscellaneous" patch into smaller patches and scattered its contents across different patches where appropriate
- Rolled in DPDK-unrelated changes into "miscellaneous" patch
- Removed unused function definition in final patch

v2:
- Split giant E610 patch into set of smaller patches
- Added release notes

Anatoly Burakov (7):
net/ixgbe/base: add definitions for E610 net/ixgbe/base: add support for E610 Admin Command Interface net/ixgbe/base: add i2c and GPIO read/write API net/ixgbe/base: add NVM init and populate net/ixgbe/base: alternate structure operations support net/ixgbe/base: support more NVM-related operations net/ixgbe/base: add various miscellaneous features

Barbara Skobiej (3):
net/ixgbe/base: remove circular header dependency net/ixgbe/base: add missing QV defines net/ixgbe/base: improve SWFW semaphore acquisition

Chinh T Cao (1):
net/ixgbe/base: remove prototypes of unimplemented functions

Dawid Zielinski (1):
net/ixgbe/base: prevent untrusted loop bound

Jakub Chylkowski (3):
net/ixgbe/base: rename message type macros net/ixgbe/base: correct registers names to match datasheet net/ixgbe/base: introduce new mailbox API

Krzysztof Galazka (1):
net/ixgbe/base: filter out spurious link up indication

Marcin Jurczak (1):
net/ixgbe/base: remove non-inclusive language

Mical MarekX (1):
net/ixgbe/base: replace HIC with direct register access

Piotr Kwapulinski (4):
net/ixgbe/base: add support for E610 device capabilities detection net/ixgbe/base: add link management support for E610 device net/ixgbe/base: add support for NVM handling in E610 device net/ixgbe/base: enable E610 device support

Piotr Pietruszewski (1):
net/ixgbe/base: revert remove default advertising for x550 2.5G/5G

Piotr Skajewski (2):
net/ixgbe/base: fix wrong 5G link speed reported on VF net/ixgbe/base: handle -Wimplicit-fallthrough

Radoslaw Tyl (4):
net/ixgbe/base: fix PHY ID for X550
net/ixgbe/base: increase DCB BW calculation for MTU from 4088 to 9128 net/ixgbe/base: improve function comments
net/ixgbe/base: add fw_rst_cnt field to ixgbe_hw struct

Slawomir Mrozowicz (1):
net/ixgbe/base: added link state handling

 doc/guides/rel_notes/release_24_07.rst   |    4 +
 drivers/net/ixgbe/base/README            |    6 +-
 drivers/net/ixgbe/base/ixgbe_82599.c     |   20 +-
 drivers/net/ixgbe/base/ixgbe_api.c       |   64 +-
 drivers/net/ixgbe/base/ixgbe_api.h       |    8 +-
 drivers/net/ixgbe/base/ixgbe_common.c    |  105 +-
 drivers/net/ixgbe/base/ixgbe_common.h    |    2 +-
 drivers/net/ixgbe/base/ixgbe_dcb.c       |    2 +-
 drivers/net/ixgbe/base/ixgbe_dcb.h       |    4 +-
 drivers/net/ixgbe/base/ixgbe_e610.c      | 4986 ++++++++++++++++++++++
 drivers/net/ixgbe/base/ixgbe_e610.h      |  165 +
 drivers/net/ixgbe/base/ixgbe_hv_vf.c     |   17 +-
 drivers/net/ixgbe/base/ixgbe_mbx.c       |  862 +++-
 drivers/net/ixgbe/base/ixgbe_mbx.h       |   87 +-
 drivers/net/ixgbe/base/ixgbe_osdep.c     |   47 +
 drivers/net/ixgbe/base/ixgbe_osdep.h     |   19 +-
 drivers/net/ixgbe/base/ixgbe_phy.c       |   15 +-
 drivers/net/ixgbe/base/ixgbe_type.h      |  130 +-
 drivers/net/ixgbe/base/ixgbe_type_e610.h | 2186 ++++++++++
 drivers/net/ixgbe/base/ixgbe_vf.c        |  103 +-
 drivers/net/ixgbe/base/ixgbe_vf.h        |    1 +
 drivers/net/ixgbe/base/ixgbe_x540.c      |    4 +-
 drivers/net/ixgbe/base/ixgbe_x550.c      |  140 +-
 drivers/net/ixgbe/base/ixgbe_x550.h      |    6 -
 drivers/net/ixgbe/base/meson.build       |    4 +-
 drivers/net/ixgbe/ixgbe_ethdev.c         |   12 +-
 drivers/net/ixgbe/ixgbe_pf.c             |   16 +-
 27 files changed, 8483 insertions(+), 532 deletions(-)
 create mode 100644 drivers/net/ixgbe/base/ixgbe_e610.c
 create mode 100644 drivers/net/ixgbe/base/ixgbe_e610.h
 create mode 100644 drivers/net/ixgbe/base/ixgbe_osdep.c
 create mode 100644 drivers/net/ixgbe/base/ixgbe_type_e610.h
Signature · 1 line
2.43.0