Skip to content

use network helpers, part 5

Geliang Tang bpf linux-kselftest 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 1 replyIn review 5 of 7 applied
  2. v46 patches 3 repliesSuperseded
  3. v38 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches2 repliesSuperseded
v14 patches0 repliesSuperseded

Changes in v5 from the cover letter

- address Martin's comments in v4 (thanks)
- add patch 4, use start_server_str in test_dctcp_fallback too
- ASSERT_* is already used in settcpca, use this helper in cc_cb (patch 3) and stg_post_socket_cb (patch 6)
- add ASSERT_* in stg_post_socket_cb in patch 6

Patches in v5 5 of 7 applied

#Subject and filesSizeRepliesApplied
1/7selftests/bpf: Drop struct post_socket_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c +1 more+5 -70 repliesApplied
2/7selftests/bpf: Add start_server_str helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+18 -60 repliesApplied
3/7selftests/bpf: Use post_socket_cb in connect_to_fd_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c+19 -50 repliesApplied
4/7selftests/bpf: Use post_socket_cb in start_server_strtools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c+8 -40 repliesApplied
5/7selftests/bpf: Use start_server_str in do_test in bpf_tcp_catools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c+55 -110 repliesApplied
6/7selftests/bpf: Use connect_to_fd_opts in do_test in bpf_tcp_catools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c+22 -201 reply
7/7selftests/bpf: Add post_connect_cb callbacktools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c+31 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH bpf-next v5 0/7] use network helpers, part 5

From: Geliang Tang <[email protected]>

This patchset uses post_socket_cb and post_connect_cb callbacks of struct network_helper_opts to refactor do_test() in bpf_tcp_ca.c to move dctcp test dedicated code out of do_test() into test_dctcp().

v5:
- address Martin's comments in v4 (thanks)
- add patch 4, use start_server_str in test_dctcp_fallback too
- ASSERT_* is already used in settcpca, use this helper in cc_cb (patch 3) and stg_post_socket_cb (patch 6)
- add ASSERT_* in stg_post_socket_cb in patch 6

v4:
- address Martin's comments in v3 (thanks).
- drop 2 patches, keep "type" as the individual arg to start_server_addr, connect_to_addr and start_server_str.

v3:
- Add 4 new patches, 1-3 are cleanups. 4 adds a new helper.
- address Martin's comments in v2.

v2:
- rebased on commit "selftests/bpf: Add test for the use of new args in cong_control"

Geliang Tang (7):
selftests/bpf: Drop struct post_socket_opts selftests/bpf: Add start_server_str helper selftests/bpf: Use post_socket_cb in connect_to_fd_opts selftests/bpf: Use post_socket_cb in start_server_str selftests/bpf: Use start_server_str in do_test in bpf_tcp_ca selftests/bpf: Use connect_to_fd_opts in do_test in bpf_tcp_ca selftests/bpf: Add post_connect_cb callback

 tools/testing/selftests/bpf/network_helpers.c |  39 +++--
 tools/testing/selftests/bpf/network_helpers.h |   9 +-
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     | 153 +++++++++++++-----
 .../bpf/prog_tests/sockopt_inherit.c          |   2 +-
 .../bpf/test_tcp_check_syncookie_user.c       |   4 +-
 5 files changed, 145 insertions(+), 62 deletions(-)
Signature · 1 line
2.43.0