Skip to content

Constify struct lib80211_crypto_ops

Christophe JAILLET kernel-janitors linux-staging linux-wireless lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- patch 1: Update ipw2x00/libipw_wx.c as well [Simon Horman]
- patch 2, 3 : no changes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib80211: Handle const struct lib80211_crypto_ops in lib80211drivers/net/wireless/intel/ipw2x00/libipw_wx.c drivers/staging/rtl8192e/rtllib_wx.c include/net/lib80211.h +1 more+10 -101 reply
2/3lib80211: Constify struct lib80211_crypto_opsnet/wireless/lib80211.c net/wireless/lib80211_crypt_ccmp.c net/wireless/lib80211_crypt_tkip.c +1 more+4 -41 reply
3/3staging: rtl8192e: Constify struct lib80211_crypto_opsdrivers/staging/rtl8192e/rtllib_crypt_ccmp.c drivers/staging/rtl8192e/rtllib_crypt_tkip.c drivers/staging/rtl8192e/rtllib_crypt_wep.c+3 -33 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSimon HormanPhilipp HortmannGreg Kroah-Hartman
1/3R-b
2/3R-b
3/3R-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] Constify struct lib80211_crypto_ops

This serie constify struct lib80211_crypto_ops. This sutructure is mostly some function pointers, so having it in a read-only section when possible is safer.

The 1st patch, update some function prototypes and data structures in lib80211.

The 2nd patch constifies some struct lib80211_crypto_ops in lib80211. This moves some data to a read-only section, so increase overall security.

The 3rd patch does the same for staging/rtl8192e.

Note that the functions have looked in staging/rtl8192e look really similar to the ones in lib80211. Maybe it could be removed in favor of the latter.

Each patch in the serie has been compile tested only.

Changes in v2:
- patch 1: Update ipw2x00/libipw_wx.c as well [Simon Horman]
- patch 2, 3 : no changes

Christophe JAILLET (3):
lib80211: Handle const struct lib80211_crypto_ops in lib80211
lib80211: Constify struct lib80211_crypto_ops
staging: rtl8192e: Constify struct lib80211_crypto_ops

 drivers/net/wireless/intel/ipw2x00/libipw_wx.c |  2 +-
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c   |  2 +-
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c   |  2 +-
 drivers/staging/rtl8192e/rtllib_crypt_wep.c    |  2 +-
 drivers/staging/rtl8192e/rtllib_wx.c           |  2 +-
 include/net/lib80211.h                         |  8 ++++----
 net/wireless/lib80211.c                        | 10 +++++-----
 net/wireless/lib80211_crypt_ccmp.c             |  2 +-
 net/wireless/lib80211_crypt_tkip.c             |  2 +-
 net/wireless/lib80211_crypt_wep.c              |  2 +-
 10 files changed, 17 insertions(+), 17 deletions(-)
Signature · 1 line
2.45.2