Skip to content

btrfs: avoid data races when accessing an inode's delayed_node

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: always set an inode's delayed_inode with WRITE_ONCE()fs/btrfs/delayed-inode.c+3 -31 reply
2/3btrfs: use READ_ONCE() when accessing delayed_node at btrfs_dirty_node()fs/btrfs/inode.c+1 -11 reply
3/3btrfs: add and use helpers to get and set an inode's delayed_nodefs/btrfs/btrfs_inode.h fs/btrfs/delayed-inode.c fs/btrfs/inode.c+19 -71 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: avoid data races when accessing an inode's delayed_node

From: Filipe Manana <[email protected]>

We do have some data races when accessing an inode's delayed_node, namely we use READ_ONCE() in a couple places while there's no pairing WRITE_ONCE() anywhere, and in one place (btrfs_dirty_inode()) we neither user READ_ONCE() nor take the lock that protects the delayed_node. So fix these and add helpers to access and update an inode's delayed_node.

Filipe Manana (3):
btrfs: always set an inode's delayed_inode with WRITE_ONCE()
btrfs: use READ_ONCE() when accessing delayed_node at btrfs_dirty_node()
btrfs: add and use helpers to get and set an inode's delayed_node

 fs/btrfs/btrfs_inode.h   | 12 ++++++++++++
 fs/btrfs/delayed-inode.c | 10 +++++-----
 fs/btrfs/inode.c         |  4 ++--
 3 files changed, 19 insertions(+), 7 deletions(-)
Signature · 1 line
2.43.0