btrfs: avoid data races when accessing an inode's delayed_node
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: always set an inode's delayed_inode with WRITE_ONCE()fs/ | +3 | 1 reply | |
| 2/3 | btrfs: use READ_ONCE() when accessing delayed_node at btrfs_dirty_node()fs/ | +1 | 1 reply | |
| 3/3 | btrfs: add and use helpers to get and set an inode's delayed_nodefs/ fs/ fs/ | +19 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Qu Wenruo |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] btrfs: avoid data races when accessing an inode's delayed_node
From: Filipe Manana <[email protected]>
We do have some data races when accessing an inode's delayed_node, namely we use READ_ONCE() in a couple places while there's no pairing WRITE_ONCE() anywhere, and in one place (btrfs_dirty_inode()) we neither user READ_ONCE() nor take the lock that protects the delayed_node. So fix these and add helpers to access and update an inode's delayed_node.
Filipe Manana (3):
btrfs: always set an inode's delayed_inode with WRITE_ONCE()
btrfs: use READ_ONCE() when accessing delayed_node at btrfs_dirty_node()
btrfs: add and use helpers to get and set an inode's delayed_node
fs/btrfs/btrfs_inode.h | 12 ++++++++++++ fs/btrfs/delayed-inode.c | 10 +++++----- fs/btrfs/inode.c | 4 ++-- 3 files changed, 19 insertions(+), 7 deletions(-)
Signature · 1 line
2.43.0