Skip to content

Allow platform drivers to update UIC command timeout

Bao D. Nguyen linux-scsi lkml 5 versions – Applied

Status from this message: Applied to 6.12/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 2 repliesApplied
  2. v41 patch 3 repliesSuperseded
  3. v31 patch 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch3 repliesSuperseded
v12 patches12 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/1scsi: ufs: core: Support Updating UIC Command Timeoutdrivers/ufs/core/ufshcd.c+24 -52 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchBart Van AsscheManivannan SadhasivamPeter Wang
1/1R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/1] Allow platform drivers to update UIC command timeout

The UIC command timeout default value remains as 500ms.

Allow platform drivers to change the UIC command timeout as they wish. During product development where a lot of debug logging/printing can occur, the uart may print from different modules with interrupt disabled for more than 500ms, causing interrupt starvation and UIC command timeout as a result. The UIC command timeout may eventually cause a watchdog timeout unnecessarily. With this change, the platform drivers can set a different UIC command timeout as desired. The supported values range from 500ms to 2 seconds.

v4 -> v5: - Changed the logic in the function uic_cmd_timeout_set()
using param_set_uint_minmax() as suggested by Peter Wang.
- Add a space in front of the module description string for better alignment.
v3 -> v4: - Addressed Bart's concern about the two string to int conversions
would yield different results.
v2 -> v3: - Addressed Bart's comments. Renamed UIC_CMD_TIMEOUT to
UIC_CMD_TIMEOUT_DEFAULT. Changed "Default.." to "Defaults..". Removed an extra line in the module description.
v1 -> v2: - Created kernel module parameter namely uic_cmd_timeout
as recommended by Bart. Addressed some other comments.
- Un-do the change in the include/ufs/ufshcd.h file
which added the uic_cmd_timeout field to the hba struct.
- Removed the patch 2 in the series where the UIC command timeout value was overridden by the platform driver.

Bao D. Nguyen (1):
scsi: ufs: core: Support Updating UIC Command Timeout

 drivers/ufs/core/ufshcd.c | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)
Signature · 1 line
2.7.4