Skip to content

btrfs: avoid some unnecessary commit of empty transactions

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs: qgroup: avoid start/commit empty transaction when flushing reservationsfs/btrfs/qgroup.c+7 -50 replies
2/7btrfs: avoid create and commit empty transaction when committing superfs/btrfs/disk-io.c+7 -30 replies
3/7btrfs: send: make ensure_commit_roots_uptodate() simpler and more efficientfs/btrfs/send.c+15 -180 replies
4/7btrfs: send: avoid create/commit empty transaction at ensure_commit_roots_uptodate()fs/btrfs/send.c+6 -30 replies
5/7btrfs: scrub: avoid create/commit empty transaction at finish_extent_writes_for_zoned()fs/btrfs/scrub.c+7 -30 replies
6/7btrfs: add and use helper to commit the current transactionfs/btrfs/disk-io.c fs/btrfs/qgroup.c fs/btrfs/scrub.c +5 more+30 -750 replies
7/7btrfs: send: get rid of the label and gotos at ensure_commit_roots_uptodate()fs/btrfs/send.c+2 -100 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosef BacikQu WenruoDavid Sterba
SeriesR-b R-b R-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] btrfs: avoid some unnecessary commit of empty transactions

From: Filipe Manana <[email protected]>

A few places can unnecessarily create an empty transaction and then commit it, when the goal is just to catch the current transaction and wait for its commit to complete. This results in wasting IO, time and rotation of the precious backup roots in the super block. Details in the change logs. The patches are all independent, except patch 4 that applies on top of patch 3 (but could have been done in any order really, they are independent).

Filipe Manana (7):
btrfs: qgroup: avoid start/commit empty transaction when flushing reservations
btrfs: avoid create and commit empty transaction when committing super
btrfs: send: make ensure_commit_roots_uptodate() simpler and more efficient
btrfs: send: avoid create/commit empty transaction at ensure_commit_roots_uptodate()
btrfs: scrub: avoid create/commit empty transaction at finish_extent_writes_for_zoned()
btrfs: add and use helper to commit the current transaction
btrfs: send: get rid of the label and gotos at ensure_commit_roots_uptodate()

 fs/btrfs/disk-io.c     |  8 +-------
 fs/btrfs/qgroup.c      | 31 +++++--------------------------
 fs/btrfs/scrub.c       |  6 +-----
 fs/btrfs/send.c        | 32 ++++++++------------------------
 fs/btrfs/space-info.c  |  9 +--------
 fs/btrfs/super.c       | 11 +----------
 fs/btrfs/transaction.c | 19 +++++++++++++++++++
 fs/btrfs/transaction.h |  1 +
 8 files changed, 37 insertions(+), 80 deletions(-)
Signature · 1 line
2.43.0