Skip to content

btrfs: basic header cleanups

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: cleanup recursive include of the same headerfs/btrfs/btrfs_inode.h fs/btrfs/extent_map.h fs/btrfs/fs.h +2 more+0 -52 replies
2/2btrfs: do not directly rwlock_types.hfs/btrfs/extent_map.h+1 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFilipe MananaDavid Sterba
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: basic header cleanups

While reading headers, clangd would do a lot of extra checks, from the very basic like including the header itself, to missing type definition inside the header's include chain.

There are 2 very basic fixes can be done immediately:

- Do not do recursive include

- Do not include rwlock_types.h
As it already mentioned to include spinlock_types.h instead.

Qu Wenruo (2):
btrfs: cleanup recursive include of the same header
btrfs: do not directly rwlock_types.h

 fs/btrfs/btrfs_inode.h | 1 -
 fs/btrfs/extent_map.h  | 3 +--
 fs/btrfs/fs.h          | 1 -
 fs/btrfs/locking.h     | 1 -
 fs/btrfs/lru_cache.h   | 1 -
 5 files changed, 1 insertion(+), 6 deletions(-)
Signature · 1 line
2.45.1