Skip to content

backends/hostmem: Report more errors on failures

Michal Privoznik qemu-devel 4 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesApplied
  2. v34 patches 8 repliesSuperseded
  3. v24 patches 12 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches5 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5meson: Don't even detect posix_madvise() on Darwinmeson.build+10 -40 replies
2/5osdep: Make qemu_madvise() to set errno in all casesutil/osdep.c+6 -10 replies
3/5osdep: Make qemu_madvise() return ENOSYS on unsupported OSesutil/osdep.c+1 -10 replies
4/5backends/hostmem: Report error on qemu_madvise() failuresbackends/hostmem.c+28 -80 replies
5/5backends/hostmem: Report error when memory size is unalignedbackends/hostmem.c+10 -01 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMario CasqueroDavid Hildenbrand
1/5
2/5R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] backends/hostmem: Report more errors on failures

v4 of:

https://mail.gnu.org/archive/html/qemu-devel/2024-05/msg06511.html

diff to v3:
- In 2/5 instead of fixing up posix_madvise() retval at runtime, just don't use posix_madvise() on Darwin at all (resulted in new patch 1/5). Since 2/5 is now the same as 1/4 from v2 I'm including David's Reviewed-by line.
- The last patch was tested by Mario, so I've included his Tested-by line. Thanks!

Michal Privoznik (5):
meson: Don't even detect posix_madvise() on Darwin
osdep: Make qemu_madvise() to set errno in all cases
osdep: Make qemu_madvise() return ENOSYS on unsupported OSes backends/hostmem: Report error on qemu_madvise() failures backends/hostmem: Report error when memory size is unaligned

 backends/hostmem.c | 46 ++++++++++++++++++++++++++++++++++++++--------
 meson.build        | 14 ++++++++++----
 util/osdep.c       |  9 +++++++--
 3 files changed, 55 insertions(+), 14 deletions(-)
Signature · 1 line
2.44.1