Skip to content

dst_cache: cope with device removal

Paolo Abeni netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ipv6: use a new flag to indicate elevated refcount.include/net/ip6_fib.h net/ipv6/route.c+5 -20 replies
2/3ipv4: obsolete routes moved out of per cpu cachenet/ipv4/route.c+1 -10 replies
3/3dst_cache: let rt_uncached cope with dst_cache cleanupnet/core/dst_cache.c+8 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] dst_cache: cope with device removal

Eric reported a net device refcount leak and diagnosed the root cause as the dst_cache not coping well with the underlying device removal.

To address such issue, this series introduces the infrastructure to let the existing uncached list handle the relevant cleanup.

Patch 1 and 2 are preparation changes to make the uncached list infra more flexible for the new use-case, and patch 3 addresses the issue.

---
Targeting net-next as the addressed problem is quite ancient and I fear some unexpected side effects for patch 2.

Paolo Abeni (3):
ipv6: use a new flag to indicate elevated refcount.
ipv4: obsolete routes moved out of per cpu cache
dst_cache: let rt_uncached cope with dst_cache cleanup

 include/net/ip6_fib.h | 3 +++
 net/core/dst_cache.c  | 8 ++++++++
 net/ipv4/route.c      | 2 +-
 net/ipv6/route.c      | 4 ++--
 4 files changed, 14 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.2