Skip to content

btrfs-progs: btrfstune: fix false alerts on dev-replace when changing csum

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: print-tree: add support for dev-replace itemkernel-shared/print-tree.c+79 -00 replies
2/2btrfs-progs: change-csum: handle finished dev-replace correctlytune/change-csum.c+15 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs-progs: btrfstune: fix false alerts on dev-replace when changing csum

There is a bug report that if a btrfs has experienced any dev-replace, "btrfstune --csum" would always report a running dev-replace and refuse to continue.

It turns out that, DEV_REPLACE item is not a transient one (but not created properly as mkfs time either), after a dev-replace the DEV_REPLACE item would exist forever, recording the last dev-replace timestamp.

Although I really hate such behavior (especially when balance item would be gone after a balance is finished/canceled), at least fix the problem first.

The first patch enhances the print-tree to properly output the contents of the dev-replace item, then the second patch fixes the problem.

I'd like to add test cases for it, but it turns out there is no csum change test cases.
My guess is we do not have proper way to skip the test if it's experiemental feature?

Maybe it's time to move csum change out of experiemental features?

Qu Wenruo (2):
btrfs-progs: print-tree: add support for dev-replace item
btrfs-progs: change-csum: handle finished dev-replace correctly

 kernel-shared/print-tree.c | 79 ++++++++++++++++++++++++++++++++++++++
 tune/change-csum.c         | 18 +++++++--
 2 files changed, 94 insertions(+), 3 deletions(-)

--
2.45.1