Skip to content

support/download: allow downloading unlocked cargo packages (branch yem/cargo-unchained)

Yann E. MORIN buildroot 2 versions – Applied

Status from this message: Applied these to master, except for python-bcrypt as explained separately.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest20 patches 12 repliesApplied
  2. v116 patches 8 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/20package/pkg-download: symplify calling parameterspackage/pkg-download.mk package/pkg-generic.mk+19 -200 replies
2/20package/pkg-generic: split long, unreadable DOWNLOAD linepackage/pkg-generic.mk+6 -10 replies
3/20utils/check-package: add option to run the test-suiteutils/check-package utils/checkpackagelib/readme.txt+11 -01 reply
4/20utils/checkpackagelib: instruct shellcheck to follow included filesutils/checkpackagelib/tool.py+1 -11 reply
5/20support/download/dl-wrapper: fix shellcheck errors.checkpackageignore support/download/dl-wrapper+14 -70 replies
6/20support/download/cargo-post-process: fix shellcheck.checkpackageignore support/download/cargo-post-process+2 -20 replies
7/20support/download: move tracing functions to helperssupport/download/dl-wrapper support/download/helpers+7 -50 replies
8/20support/download: pass post-process options to post-process helperpackage/pkg-generic.mk support/download/dl-wrapper+6 -30 replies
9/20support/download: accept manifest path as a post-process optionsupport/download/cargo-post-process+4 -20 replies
10/20pakcage/pkg-cargo: use post-process opts to pass manifest pathpackage/pkg-cargo.mk+1 -11 reply
11/20package/pkg-python: use post-process opts to pass Cargo manifest pathpackage/pkg-python.mk+3 -30 replies
12/20package/python-bcrypt: use post-process opts to pass Cargo manifest pathpackage/python-bcrypt/python-bcrypt.mk+2 -33 replies
13/20support/download: no longer support BR_CARGO_MANIFEST_PATH in cargo post-processsupport/download/cargo-post-process+6 -10 replies
14/20docs/manual: rephrase end of vendoring sectiondocs/manual/adding-packages-cargo.adoc+2 -51 reply
15/20package/pkg-cargo: add support for unlocked packagesdocs/manual/adding-packages-cargo.adoc package/pkg-cargo.mk support/download/cargo-post-process+66 -60 replies
16/20utils/checkpackagelib: add test for default _CARGO_LOCKEDutils/checkpackagelib/lib_mk.py utils/checkpackagelib/test_lib_mk.py+26 -00 replies
17/20RFC: package/anvil: new packagepackage/Config.in package/anvil/Config.in package/anvil/anvil.mk+51 -01 reply
18/20package/pkg-utils: accept pacakge-specific archive format versionpackage/pkg-utils.mk+2 -10 replies
19/20package/pkg-cargo: allow unlocked packages to provide local Cargo.lockdocs/manual/adding-packages-cargo.adoc package/pkg-cargo.mk support/download/cargo-post-process+51 -112 replies
20/20RFC: package/anvil: add local Cargo.lockpackage/anvil/Cargo.lock package/anvil/anvil.hash package/anvil/anvil.mk+3469 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Buildroot] [PATCH 00/20 v2] support/download: allow downloading unlocked cargo packages (branch yem/cargo-unchained)

Hello All!

Some maintainers refuse to commit a Cargo.lock in their repository [0], so there are cargo packages that are unlocked.

However, we currently require that a Cargo.lock be present: we call "cargo venodor --locked"; if there is no Cargo.lock, cargo fails.

This series adds support for downloading unlocked cargo packages; the series is articulated in three steps:

1. preparatory cleanups (shelcheck, readability...)

2. extend the download infra to pass arbitrary options to the post-process helpers; use that to pass the path of the manifest instead of using an environment variable

3. add support for unlocked cargo packages by passing a new option to the cargo post-process helper; add documentation and check-package.

4. (off-by-one error) add an RFC-style package to demonstrate the unlocked cargo package.

Unlocked packages can be handled in two ways: totally unlocked, in which case they are not reproducible, or by providing a Cargo.lock in the Buildroot package directory, in which case it is reproducible, but there is a little bit more complexity to it, so this is implemented separately in case it is deemed too heavy-weight.

Regards,
Yann E. MORIN.

----------------------------------------------------------------
Yann E. MORIN (20):
package/pkg-download: symplify calling parameters package/pkg-generic: split long, unreadable DOWNLOAD line utils/check-package: add option to run the test-suite utils/checkpackagelib: instruct shellcheck to follow included files support/download/dl-wrapper: fix shellcheck errors support/download/cargo-post-process: fix shellcheck support/download: move tracing functions to helpers support/download: pass post-process options to post-process helper support/download: accept manifest path as a post-process option pakcage/pkg-cargo: use post-process opts to pass manifest path package/pkg-python: use post-process opts to pass Cargo manifest path package/python-bcrypt: use post-process opts to pass Cargo manifest path support/download: no longer support BR_CARGO_MANIFEST_PATH in cargo post-process docs/manual: rephrase end of vendoring section
package/pkg-cargo: add support for unlocked packages utils/checkpackagelib: add test for default _CARGO_LOCKED
RFC: package/anvil: new package
package/pkg-utils: accept pacakge-specific archive format version package/pkg-cargo: allow unlocked packages to provide local Cargo.lock
RFC: package/anvil: add local Cargo.lock

 .checkpackageignore                    |    2 -
 docs/manual/adding-packages-cargo.adoc |   34 +-
 package/Config.in                      |    1 +
 package/anvil/Cargo.lock               | 3464 ++++++++++++++++++++++++++++++++
 package/anvil/Config.in                |   20 +
 package/anvil/anvil.hash               |    2 +
 package/anvil/anvil.mk                 |   31 +
 package/pkg-cargo.mk                   |   31 +-
 package/pkg-download.mk                |   33 +-
 package/pkg-generic.mk                 |   12 +-
 package/pkg-python.mk                  |    6 +-
 package/pkg-utils.mk                   |    3 +-
 package/python-bcrypt/python-bcrypt.mk |    5 +-
 support/download/cargo-post-process    |   62 +-
 support/download/dl-wrapper            |   32 +-
 support/download/helpers               |    4 +
 utils/check-package                    |   10 +
 utils/checkpackagelib/lib_mk.py        |    8 +
 utils/checkpackagelib/readme.txt       |    1 +
 utils/checkpackagelib/test_lib_mk.py   |   18 +
 utils/checkpackagelib/tool.py          |    2 +-
 21 files changed, 3728 insertions(+), 53 deletions(-)
 create mode 100644 package/anvil/Cargo.lock
 create mode 100644 package/anvil/Config.in
 create mode 100644 package/anvil/anvil.hash
 create mode 100644 package/anvil/anvil.mk

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot