Skip to content

drm/i915: finish the job of removing implicit dev_priv

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest65 patches 67 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/65drm/i915: pass dev_priv explicitly to DPLLdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power_well.c +4 more+43 -401 reply
2/65drm/i915: pass dev_priv explicitly to DPLL_MDdrivers/gpu/drm/i915/display/intel_dpll.c drivers/gpu/drm/i915/i915_reg.h+12 -81 reply
3/65drm/i915: pass dev_priv explicitly to TRANS_HTOTALdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_pch_display.c +3 more+11 -111 reply
4/65drm/i915: pass dev_priv explicitly to TRANS_HBLANKdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_pch_display.c drivers/gpu/drm/i915/i915_reg.h +1 more+10 -91 reply
5/65drm/i915: pass dev_priv explicitly to TRANS_HSYNCdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_pch_display.c +2 more+11 -101 reply
6/65drm/i915: pass dev_priv explicitly to TRANS_VTOTALdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display.c +4 more+15 -141 reply
7/65drm/i915: pass dev_priv explicitly to TRANS_VBLANKdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display.c +3 more+20 -141 reply
8/65drm/i915: pass dev_priv explicitly to TRANS_VSYNCdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display.c +3 more+13 -111 reply
9/65drm/i915: pass dev_priv explicitly to BCLRPATdrivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h +1 more+12 -101 reply
10/65drm/i915: pass dev_priv explicitly to TRANS_VSYNCSHIFTdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_pch_display.c +2 more+10 -81 reply
11/65drm/i915: pass dev_priv explicitly to PIPESRCdrivers/gpu/drm/i915/display/i9xx_plane.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gvt/fb_decoder.c +2 more+11 -111 reply
12/65drm/i915: pass dev_priv explicitly to TRANS_MULTdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_gvt_mmio_table.c+6 -61 reply
13/65drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_ENdrivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_hotplug_irq.c drivers/gpu/drm/i915/i915_reg.h+4 -31 reply
14/65drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_STATdrivers/gpu/drm/i915/display/g4x_dp.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display_irq.c +3 more+15 -101 reply
15/65drm/i915: pass dev_priv explicitly to PFIT_CONTROLdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_lvds.c drivers/gpu/drm/i915/display/intel_overlay.c +1 more+9 -81 reply
16/65drm/i915: pass dev_priv explicitly to PFIT_PGM_RATIOSdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_overlay.c drivers/gpu/drm/i915/i915_reg.h+6 -51 reply
17/65drm/i915: pass dev_priv explicitly to PFIT_AUTO_RATIOSdrivers/gpu/drm/i915/display/intel_overlay.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
18/65drm/i915: pass dev_priv explicitly to TRANSCONFdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_display.c +9 more+76 -591 reply
19/65drm/i915: pass dev_priv explicitly to PIPEDSLdrivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_hdmi.c drivers/gpu/drm/i915/display/intel_vblank.c +2 more+14 -121 reply
20/65drm/i915: pass dev_priv explicitly to PIPEFRAMEdrivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
21/65drm/i915: pass dev_priv explicitly to PIPEFRAMEPIXELdrivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/i915_reg.h+3 -31 reply
22/65drm/i915: pass dev_priv explicitly to PIPESTATdrivers/gpu/drm/i915/display/intel_display_irq.c drivers/gpu/drm/i915/display/intel_fifo_underrun.c drivers/gpu/drm/i915/i915_reg.h +1 more+12 -111 reply
23/65drm/i915: pass dev_priv explicitly to PIPE_ARB_CTLdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+2 -21 reply
24/65drm/i915: pass dev_priv explicitly to ICL_PIPESTATUSdrivers/gpu/drm/i915/display/intel_fifo_underrun.c drivers/gpu/drm/i915/i915_reg.h+7 -41 reply
25/65drm/i915: pass dev_priv explicitly to DSPARBdrivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/i915_suspend.c+17 -131 reply
26/65drm/i915: pass dev_priv explicitly to DSPFW1drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/i915_reg.h+14 -131 reply
27/65drm/i915: pass dev_priv explicitly to DSPFW2drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/i915_reg.h+8 -71 reply
28/65drm/i915: pass dev_priv explicitly to DSPFW3drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/i915_reg.h+17 -141 reply
29/65drm/i915: pass dev_priv explicitly to PIPE_FRMCOUNT_G4Xdrivers/gpu/drm/i915/display/intel_vblank.c drivers/gpu/drm/i915/gvt/display.c drivers/gpu/drm/i915/i915_reg.h +1 more+7 -71 reply
30/65drm/i915: pass dev_priv explicitly to PIPE_FLIPCOUNT_G4Xdrivers/gpu/drm/i915/gvt/cmd_parser.c drivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/i915_reg.h +1 more+8 -81 reply
31/65drm/i915: pass dev_priv explicitly to CHV_BLENDdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
32/65drm/i915: pass dev_priv explicitly to CHV_CANVASdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+2 -21 reply
33/65drm/i915: pass dev_priv explicitly to SWF0drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/i915_suspend.c+9 -51 reply
34/65drm/i915: pass dev_priv explicitly to SWF1drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/i915_suspend.c+13 -71 reply
35/65drm/i915: pass dev_priv explicitly to SWF3drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/i915_suspend.c+9 -51 reply
36/65drm/i915: pass dev_priv explicitly to _PIPEBDSLdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
37/65drm/i915: pass dev_priv explicitly to _TRANSBCONFdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
38/65drm/i915: pass dev_priv explicitly to _PIPEBSTATdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
39/65drm/i915: pass dev_priv explicitly to _PIPEB_FRMCOUNT_G4Xdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
40/65drm/i915: pass dev_priv explicitly to _PIPEB_FLIPCOUNT_G4Xdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
41/65drm/i915: pass dev_priv explicitly to _DSPBCNTRdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
42/65drm/i915: pass dev_priv explicitly to _DSPBADDRdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
43/65drm/i915: pass dev_priv explicitly to _DSPBSTRIDEdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
44/65drm/i915: pass dev_priv explicitly to _DSPBPOSdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
45/65drm/i915: pass dev_priv explicitly to _DSPBSIZEdrivers/gpu/drm/i915/i915_reg.h+1 -13 replies
46/65drm/i915: pass dev_priv explicitly to _DSPBSURFdrivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/i915_reg.h+2 -21 reply
47/65drm/i915: pass dev_priv explicitly to _DSPBTILEOFFdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
48/65drm/i915: pass dev_priv explicitly to _DSPBOFFSETdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
49/65drm/i915: pass dev_priv explicitly to _DSPBSURFLIVEdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
50/65drm/i915: pass dev_priv explicitly to PIPE_DATA_M1drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_fdi.c drivers/gpu/drm/i915/gvt/display.c +2 more+16 -141 reply
51/65drm/i915: pass dev_priv explicitly to PIPE_DATA_N1drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gvt/display.c drivers/gpu/drm/i915/i915_reg.h +1 more+9 -91 reply
52/65drm/i915: pass dev_priv explicitly to PIPE_DATA_M2drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_gvt_mmio_table.c+9 -71 reply
53/65drm/i915: pass dev_priv explicitly to PIPE_DATA_N2drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_gvt_mmio_table.c+7 -71 reply
54/65drm/i915: pass dev_priv explicitly to PIPE_LINK_M1drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gvt/display.c drivers/gpu/drm/i915/gvt/handlers.c +2 more+12 -101 reply
55/65drm/i915: pass dev_priv explicitly to PIPE_LINK_N1drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gvt/display.c drivers/gpu/drm/i915/gvt/handlers.c +2 more+10 -101 reply
56/65drm/i915: pass dev_priv explicitly to PIPE_LINK_M2drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_gvt_mmio_table.c+9 -71 reply
57/65drm/i915: pass dev_priv explicitly to PIPE_LINK_N2drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_gvt_mmio_table.c+7 -71 reply
58/65drm/i915: pass dev_priv explicitly to HSW_STEREO_3D_CTLdrivers/gpu/drm/i915/i915_reg.h+1 -11 reply
59/65drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTLdrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c +8 more+58 -371 reply
60/65drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL2drivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display_irq.c +1 more+13 -71 reply
61/65drm/i915: pass dev_priv explicitly to TGL_DP_TP_CTLdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
62/65drm/i915: pass dev_priv explicitly to TGL_DP_TP_STATUSdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
63/65drm/i915: pass dev_priv explicitly to TRANS_MSA_MISCdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/i915_reg.h+3 -21 reply
64/65drm/i915: pass dev_priv explicitly to TRANS_SET_CONTEXT_LATENCYdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+5 -31 reply
65/65drm/i915: pass dev_priv explicitly to MTL_CLKGATE_DIS_TRANSdrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/i915_reg.h+4 -31 reply

Reviews trailers per patch

All 65 patches have a Reviewed-by or Acked-by.

PatchRodrigo Vivi
1/65R-b
2/65R-b
3/65R-b
4/65R-b
5/65R-b
6/65R-b
7/65R-b
8/65R-b
9/65R-b
10/65R-b
11/65R-b
12/65R-b
13/65R-b
14/65R-b
15/65R-b
16/65R-b
17/65R-b
18/65R-b
19/65R-b
20/65R-b
21/65R-b
22/65R-b
23/65R-b
24/65R-b
25/65R-b
26/65R-b
27/65R-b
28/65R-b
29/65R-b
30/65R-b
31/65R-b
32/65R-b
33/65R-b
34/65R-b
35/65R-b
36/65R-b
37/65R-b
38/65R-b
39/65R-b
40/65R-b
41/65R-b
42/65R-b
43/65R-b
44/65R-b
45/65R-b
46/65R-b
47/65R-b
48/65R-b
49/65R-b
50/65R-b
51/65R-b
52/65R-b
53/65R-b
54/65R-b
55/65R-b
56/65R-b
57/65R-b
58/65R-b
59/65R-b
60/65R-b
61/65R-b
62/65R-b
63/65R-b
64/65R-b
65/65R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/65] drm/i915: finish the job of removing implicit dev_priv

Rip the band-aid. Finish the job of removing implicit dev_priv usage. It's a lot, but it's straightforward.

BR,
Jani.

Jani Nikula (65):
drm/i915: pass dev_priv explicitly to DPLL
drm/i915: pass dev_priv explicitly to DPLL_MD drm/i915: pass dev_priv explicitly to TRANS_HTOTAL drm/i915: pass dev_priv explicitly to TRANS_HBLANK drm/i915: pass dev_priv explicitly to TRANS_HSYNC drm/i915: pass dev_priv explicitly to TRANS_VTOTAL drm/i915: pass dev_priv explicitly to TRANS_VBLANK drm/i915: pass dev_priv explicitly to TRANS_VSYNC drm/i915: pass dev_priv explicitly to BCLRPAT drm/i915: pass dev_priv explicitly to TRANS_VSYNCSHIFT drm/i915: pass dev_priv explicitly to PIPESRC drm/i915: pass dev_priv explicitly to TRANS_MULT drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_EN drm/i915: pass dev_priv explicitly to PORT_HOTPLUG_STAT drm/i915: pass dev_priv explicitly to PFIT_CONTROL drm/i915: pass dev_priv explicitly to PFIT_PGM_RATIOS drm/i915: pass dev_priv explicitly to PFIT_AUTO_RATIOS drm/i915: pass dev_priv explicitly to TRANSCONF drm/i915: pass dev_priv explicitly to PIPEDSL drm/i915: pass dev_priv explicitly to PIPEFRAME drm/i915: pass dev_priv explicitly to PIPEFRAMEPIXEL drm/i915: pass dev_priv explicitly to PIPESTAT drm/i915: pass dev_priv explicitly to PIPE_ARB_CTL drm/i915: pass dev_priv explicitly to ICL_PIPESTATUS drm/i915: pass dev_priv explicitly to DSPARB drm/i915: pass dev_priv explicitly to DSPFW1 drm/i915: pass dev_priv explicitly to DSPFW2 drm/i915: pass dev_priv explicitly to DSPFW3 drm/i915: pass dev_priv explicitly to PIPE_FRMCOUNT_G4X drm/i915: pass dev_priv explicitly to PIPE_FLIPCOUNT_G4X drm/i915: pass dev_priv explicitly to CHV_BLEND drm/i915: pass dev_priv explicitly to CHV_CANVAS drm/i915: pass dev_priv explicitly to SWF0
drm/i915: pass dev_priv explicitly to SWF1
drm/i915: pass dev_priv explicitly to SWF3
drm/i915: pass dev_priv explicitly to _PIPEBDSL drm/i915: pass dev_priv explicitly to _TRANSBCONF drm/i915: pass dev_priv explicitly to _PIPEBSTAT drm/i915: pass dev_priv explicitly to _PIPEB_FRMCOUNT_G4X drm/i915: pass dev_priv explicitly to _PIPEB_FLIPCOUNT_G4X drm/i915: pass dev_priv explicitly to _DSPBCNTR drm/i915: pass dev_priv explicitly to _DSPBADDR drm/i915: pass dev_priv explicitly to _DSPBSTRIDE drm/i915: pass dev_priv explicitly to _DSPBPOS drm/i915: pass dev_priv explicitly to _DSPBSIZE drm/i915: pass dev_priv explicitly to _DSPBSURF drm/i915: pass dev_priv explicitly to _DSPBTILEOFF drm/i915: pass dev_priv explicitly to _DSPBOFFSET drm/i915: pass dev_priv explicitly to _DSPBSURFLIVE drm/i915: pass dev_priv explicitly to PIPE_DATA_M1 drm/i915: pass dev_priv explicitly to PIPE_DATA_N1 drm/i915: pass dev_priv explicitly to PIPE_DATA_M2 drm/i915: pass dev_priv explicitly to PIPE_DATA_N2 drm/i915: pass dev_priv explicitly to PIPE_LINK_M1 drm/i915: pass dev_priv explicitly to PIPE_LINK_N1 drm/i915: pass dev_priv explicitly to PIPE_LINK_M2 drm/i915: pass dev_priv explicitly to PIPE_LINK_N2 drm/i915: pass dev_priv explicitly to HSW_STEREO_3D_CTL drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL drm/i915: pass dev_priv explicitly to TRANS_DDI_FUNC_CTL2 drm/i915: pass dev_priv explicitly to TGL_DP_TP_CTL drm/i915: pass dev_priv explicitly to TGL_DP_TP_STATUS drm/i915: pass dev_priv explicitly to TRANS_MSA_MISC drm/i915: pass dev_priv explicitly to TRANS_SET_CONTEXT_LATENCY drm/i915: pass dev_priv explicitly to MTL_CLKGATE_DIS_TRANS

 drivers/gpu/drm/i915/display/g4x_dp.c         |   2 +-
 drivers/gpu/drm/i915/display/i9xx_plane.c     |   2 +-
 drivers/gpu/drm/i915/display/i9xx_wm.c        |  87 ++++----
 drivers/gpu/drm/i915/display/icl_dsi.c        |  46 +++--
 drivers/gpu/drm/i915/display/intel_crt.c      |  50 +++--
 drivers/gpu/drm/i915/display/intel_ddi.c      |  47 +++--
 drivers/gpu/drm/i915/display/intel_display.c  | 193 ++++++++++--------
 .../drm/i915/display/intel_display_debugfs.c  |   2 +-
 .../gpu/drm/i915/display/intel_display_irq.c  |  17 +-
 .../drm/i915/display/intel_display_power.c    |   2 +-
 .../i915/display/intel_display_power_well.c   |  14 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   5 +-
 drivers/gpu/drm/i915/display/intel_dpll.c     |  63 +++---
 drivers/gpu/drm/i915/display/intel_drrs.c     |   2 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |   5 +-
 drivers/gpu/drm/i915/display/intel_fdi.c      |  15 +-
 .../drm/i915/display/intel_fifo_underrun.c    |  13 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |   3 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   5 +-
 .../gpu/drm/i915/display/intel_hotplug_irq.c  |  12 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |   2 +-
 drivers/gpu/drm/i915/display/intel_overlay.c  |  10 +-
 .../gpu/drm/i915/display/intel_pch_display.c  |  21 +-
 drivers/gpu/drm/i915/display/intel_pps.c      |   2 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   5 +-
 drivers/gpu/drm/i915/display/intel_vblank.c   |  14 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |   3 +-
 drivers/gpu/drm/i915/gvt/cmd_parser.c         |   2 +-
 drivers/gpu/drm/i915/gvt/display.c            |  59 +++---
 drivers/gpu/drm/i915/gvt/fb_decoder.c         |   6 +-
 drivers/gpu/drm/i915/gvt/handlers.c           |  28 +--
 drivers/gpu/drm/i915/i915_irq.c               |   5 +-
 drivers/gpu/drm/i915/i915_reg.h               | 130 ++++++------
 drivers/gpu/drm/i915/i915_suspend.c           |  48 +++--
 drivers/gpu/drm/i915/intel_gvt_mmio_table.c   | 180 ++++++++--------
 35 files changed, 610 insertions(+), 490 deletions(-)
Signature · 1 line
2.39.2