everywhere: use $(TAR) not tar (branch yem/tarTAR)
Status from this message: Applied to master, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 18 repliesApplied
- v19 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- fix apply-pathes (Brandon)
- drop useless tarball-patch for liblockfile
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | package/liblockfile: drop empty patch tarballpackage/ | +0 | 2 replies | |
| 2/10 | fs/tar: use appropriate TARfs/ | +1 | 1 reply | |
| 3/10 | package/cvs: use appropriate TARpackage/ | +1 | 1 reply | |
| 4/10 | package/flutter-engine: use appropriate TARpackage/ package/ | +2 | 2 replies | |
| 5/10 | package/pkg-download: export TAR for download backendspackage/ | +3 | 2 replies | |
| 6/10 | support/download/helpers: use appropriate TARsupport/ | +2 | 1 reply | |
| 7/10 | support/download/cvs: fix shellcheck.checkpackageignore support/ | +2 | 2 replies | |
| 8/10 | support/download/cvs: use appropriate TARsupport/ | +1 | 1 reply | |
| 9/10 | support/scripts/apply-patches: use appropriate TARpackage/ support/ | +2 | 3 replies | |
| 10/10 | package/sunxi-mali-utgard-driver: handle patching the Buildroot waypackage/ package/ | +40 | 2 replies |
Reviews trailers per patch
2 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Giulio Benetti | [email protected] |
|---|---|---|
| 1/10 | ||
| 2/10 | ||
| 3/10 | ||
| 4/10 | ||
| 5/10 | ||
| 6/10 | ||
| 7/10 | ||
| 8/10 | ||
| 9/10 | R-b | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 00/10 v2] everywhere: use $(TAR) not tar (branch yem/tarTAR)
Hello All!
To allow for reproducible archives, and to ensure we can extract all archives, we require that we use tar 1.35 or above.
There are then two cases:
1. the system has a suitable tar: we use that;
2. the system has no suitable tar: we build our own host-tar, and use that (it ends up in HOST_DIR/bin so is in the PATH).
However, to avoid building host-tar again and again, people can set the TAR environment variable, to point to a tar version they believe is suitable (if it is not, we fallback to case 2, above). If the user provides a suitable tar, then we do not build our own host-tar and use the one provided by the user.
However, there are a few places where we do hard-code calls to 'tar' without considering the one provided by the user. This breaks cases where an unsuitable tar is available on the system, as that unsuitable tar is then used to create and extract tarballs. This breaks generatign tarballs from VCS (git, svn) or from vendoring (cargo, go).
Fix all those cases.
How to find calls to tar:
$ git grep -E '\<tar '
There are a lot of false positive:
- CHANGES
- comments
- docs
- patches
- misc (e.g. a script with a $tar variable)
After this series, we still have a very few locations which directly call to a plain tar:
- Makefile: the 'release' target
- scripts not called as part of the build
- boards readmes
- patches
The first will be addressed in a separate patch, as it is not critical (users do not nromally cut Buildroot releases!). The others can't be changed, as they execute outside Buildroot's control.
Changes v1 -> v2:
- fix apply-pathes (Brandon)
- drop useless tarball-patch for liblockfile
Regards,
Yann E. MORIN.
----------------------------------------------------------------
Yann E. MORIN (10):
package/liblockfile: drop empty patch tarball
fs/tar: use appropriate TAR
package/cvs: use appropriate TAR package/flutter-engine: use appropriate TAR package/pkg-download: export TAR for download backends support/download/helpers: use appropriate TAR support/download/cvs: fix shellcheck support/download/cvs: use appropriate TAR support/scripts/apply-patches: use appropriate TAR package/sunxi-mali-utgard-driver: handle patching the Buildroot way
.checkpackageignore | 1 - fs/tar/tar.mk | 2 +- package/Makefile.in | 2 +- package/cvs/cvs.mk | 2 +- package/flutter-engine/flutter-engine.mk | 1 + package/flutter-engine/gen-tarball | 2 +- package/liblockfile/liblockfile.mk | 1 - package/pkg-download.mk | 4 ++- .../0001-build.sh-do-not-apply-patches.patch | 39 ++++++++++++++++++++++ .../sunxi-mali-utgard-driver.mk | 3 +- support/download/cvs | 5 +-- support/download/helpers | 4 +-- support/scripts/apply-patches.sh | 2 +- 13 files changed, 54 insertions(+), 14 deletions(-) create mode 100644 package/sunxi-mali-utgard-driver/0001-build.sh-do-not-apply-patches.patch
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot