Skip to content

use network helpers, part 7

Geliang Tang bpf linux-kselftest 6 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 0 repliesApplied 6/6
  2. v56 patches 5 repliesSuperseded
  3. v46 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches1 replySuperseded
v24 patches1 replySuperseded
v15 patches4 repliesSuperseded

Changes in v6 from the cover letter

- update ASSERT strings in patch 4 as Eduard suggested. (thanks)

Patches in v6 All 6 applied

#Subject and filesSizeRepliesApplied
1/6selftests/bpf: Drop type from network_helper_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c +2 more+26 -330 repliesApplied
2/6selftests/bpf: Use connect_to_addr in connect_to_fd_opttools/testing/selftests/bpf/network_helpers.c+7 -260 repliesApplied
3/6selftests/bpf: Add client_socket helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+31 -80 repliesApplied
4/6selftests/bpf: Drop noconnect from network_helper_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c+8 -110 repliesApplied
5/6selftests/bpf: Use start_server_str in mptcptools/testing/selftests/bpf/prog_tests/mptcp.c+1 -60 repliesApplied
6/6selftests/bpf: Use start_server_str in test_tcp_check_syncookie_usertools/testing/selftests/bpf/test_tcp_check_syncookie_user.c+3 -260 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchEduard Zingerman
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH bpf-next v6 0/6] use network helpers, part 7

From: Geliang Tang <[email protected]>

v6:
- update ASSERT strings in patch 4 as Eduard suggested. (thanks)

v5:
- update patch 1, add getsockopt(SO_PROTOCOL) in connect_to_fd() to
fix errors reported by CI.

v4:
- fix errors reported by CI.

v3:
- rename start_client to client_socket
- Use connect_to_addr in connect_to_fd_opt

v2:
- update patch 2, extract a new helper start_client.
- drop patch 3, keep must_fail in network_helper_opts.

Drop type and noconnect from network_helper_opts. And use start_server_str in mptcp and test_tcp_check_syncookie_user.

Patches 1-4 address Martin's comments in the previous series.

Geliang Tang (6):
selftests/bpf: Drop type from network_helper_opts selftests/bpf: Use connect_to_addr in connect_to_fd_opt selftests/bpf: Add client_socket helper
selftests/bpf: Drop noconnect from network_helper_opts selftests/bpf: Use start_server_str in mptcp selftests/bpf: Use start_server_str in test_tcp_check_syncookie_user

 tools/testing/selftests/bpf/network_helpers.c | 100 +++++++++---------
 tools/testing/selftests/bpf/network_helpers.h |   6 +-
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |   2 +-
 .../selftests/bpf/prog_tests/cgroup_v1v2.c    |   4 +-
 .../bpf/prog_tests/ip_check_defrag.c          |  14 ++-
 .../testing/selftests/bpf/prog_tests/mptcp.c  |   7 +-
 .../bpf/test_tcp_check_syncookie_user.c       |  29 +----
 7 files changed, 64 insertions(+), 98 deletions(-)
Signature · 1 line
2.43.0