Skip to content

drm/panic: Fixes and graphical logo

Geert Uytterhoeven dri-devel linux-fbdev linux-renesas-soc oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 16 repliesIn review
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Rebase against today's drm-misc-next, where drm_panic is broken on all current drivers due to an uninitialized pointer dereference. Presumably this was only tested with an out-of-tree driver change?
- New fixes [1/7], [3/7], and [4/7],
- New cleanup [5/7],
- Inline trivial draw_logo_mono().

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/panic: Fix uninitialized drm_scanout_buffer.set_pixel() crashdrivers/gpu/drm/drm_panic.c+1 -11 reply
2/7drm/panic: Fix off-by-one logo size checksdrivers/gpu/drm/drm_panic.c+1 -11 reply
3/7lib/fonts: Fix visiblity of SUN12x22 and TER16x32 if DRM_PANIClib/fonts/Kconfig+4 -21 reply
4/7drm/panic: Spelling s/formater/formatter/drivers/gpu/drm/Kconfig+1 -11 reply
5/7drm/panic: Convert to drm_fb_clip_offset()drivers/gpu/drm/drm_panic.c+2 -24 replies
6/7drm/panic: Rename logo to logo_asciidrivers/gpu/drm/drm_panic.c+6 -51 reply
7/7drm/panic: Add support for drawing a monochrome graphical logodrivers/gpu/drm/drm_panic.c drivers/video/logo/Kconfig+60 -75 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] drm/panic: Fixes and graphical logo

Hi all,

If drm/panic is enabled, a user-friendly message is shown on screen when a kernel panic occurs, together with an ASCII art penguin logo. Of course we can do better ;-)
Hence this patch series extends drm/panic to draw the monochrome graphical boot logo, when available, preceded by the customary fixes.

Changes compared to v1:
- Rebase against today's drm-misc-next, where drm_panic is broken on all current drivers due to an uninitialized pointer dereference. Presumably this was only tested with an out-of-tree driver change?
- New fixes [1/7], [3/7], and [4/7],
- New cleanup [5/7],
- Inline trivial draw_logo_mono().

This has been tested with rcar-du.

Thanks for your comments!

Geert Uytterhoeven (7):
drm/panic: Fix uninitialized drm_scanout_buffer.set_pixel() crash drm/panic: Fix off-by-one logo size checks
lib/fonts: Fix visiblity of SUN12x22 and TER16x32 if DRM_PANIC drm/panic: Spelling s/formater/formatter/
drm/panic: Convert to drm_fb_clip_offset()
drm/panic: Rename logo to logo_ascii
drm/panic: Add support for drawing a monochrome graphical logo

 drivers/gpu/drm/Kconfig     |  2 +-
 drivers/gpu/drm/drm_panic.c | 74 +++++++++++++++++++++++++++++++------
 drivers/video/logo/Kconfig  |  2 +
 lib/fonts/Kconfig           |  6 ++-
 4 files changed, 70 insertions(+), 14 deletions(-)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds