Skip to content

btrfs-progs: btrfs-progs: csum-change enhancement

Qu Wenruo linux-btrfs 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 0 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Rebased to the latest devel branch
- Migrate to use "btrfs --version" to detect features

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: csum-change: add leaf based thresholdtune/change-csum.c+52 -160 replies
2/3btrfs-progs: tests: use feature output from "btrfs --version"tests/common+1 -50 replies
3/3btrfs-progs: misc-tests: add a basic resume test using error injectiontests/common tests/misc-tests/065-csum-conversion-inject/test.sh+52 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] btrfs-progs: btrfs-progs: csum-change enhancement

[CHANGELOG]
v3:
- Rebased to the latest devel branch
- Migrate to use "btrfs --version" to detect features

v2:
- Enhance the error injection detection
Now instead of plain run_mustfail, we do check both the failure and the stderr.
Only when the csum-change failed and stderr includes the injection cookie output, we know it's really the injection causing error.

The first two patches are small enhancement and bugfix:

- Fix a missing error handling
- Do multi-transaction csum deletion and rename
Or we can generate GiB or even TiB level of dirty metadata.

Finally introduce a basic error injection based test case, which will:

- Check if we have error injection first
- Inject error at the end of data csum generation
- Make sure resume from above situation is correct

I'm not adding extra injections because I believe there would definitely be corner cases that need to be fixed.

Qu Wenruo (3):
btrfs-progs: csum-change: add leaf based threshold
btrfs-progs: tests: use feature output from "btrfs --version"
btrfs-progs: misc-tests: add a basic resume test using error injection

 tests/common                                  | 13 ++--
 .../065-csum-conversion-inject/test.sh        | 45 ++++++++++++
 tune/change-csum.c                            | 68 ++++++++++++++-----
 3 files changed, 105 insertions(+), 21 deletions(-)
 create mode 100755 tests/misc-tests/065-csum-conversion-inject/test.sh

--
2.45.2