use network helpers, part 8
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest9 patches 4 repliesIn review 6 of 9 applied
- v1012 patches 4 repliesSuperseded
- v911 patches 1 replySuperseded
Earlier versions · 8
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 | 9 patches | 1 reply | Superseded | |
| v7 | 9 patches | 1 reply | Superseded | |
| v6 | 9 patches | 5 replies | Superseded | |
| v5 | 9 patches | 1 reply | Superseded | |
| v4 | 9 patches | 3 replies | Superseded | |
| v3 | 8 patches | 0 replies | Superseded | |
| v2 | 7 patches | 0 replies | Superseded | |
| v1 | 6 patches | 5 replies | Superseded |
Changes in v11 from the cover letter
- new patches 2, 4, 6.
- drop expect_errno from network_helper_opts as Eduard and Martin suggested.
- drop sockmap_ktls patches from this set.
- add a new helper connect_fd_to_addr_str.
Patches in v11 6 of 9 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | selftests/bpf: Add backlog for network_helper_optstools/ tools/ | +5 | 0 replies | Applied |
| 2/9 | selftests/bpf: Add ASSERT_OK_FD macrotools/ | +8 | 1 reply | Applied |
| 3/9 | selftests/bpf: Close fd in error path in drop_on_reuseporttools/ | +1 | 1 reply | Applied |
| 4/9 | selftests/bpf: Use start_server_str in sk_lookuptools/ | +34 | 0 replies | Applied |
| 5/9 | selftests/bpf: Use start_server_addr in sk_lookuptools/ | +2 | 0 replies | Applied |
| 6/9 | selftests/bpf: Use connect_fd_to_fd in sk_lookuptools/ | +2 | 1 reply | Applied |
| 7/9 | selftests/bpf: Add connect_fd_to_addr_str helpertools/ tools/ | +24 | 1 reply | |
| 8/9 | selftests/bpf: Use connect_fd_to_addr_str in sk_lookuptools/ | +8 | 0 replies | |
| 9/9 | selftests/bpf: Drop make_socket in sk_lookuptools/ | +8 | 0 replies |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Eduard Zingerman |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | A-b |
| 4/9 | A-b |
| 5/9 | A-b |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf-next v11 0/9] use network helpers, part 8
From: Geliang Tang <[email protected]>
v11:
- new patches 2, 4, 6.
- drop expect_errno from network_helper_opts as Eduard and Martin suggested.
- drop sockmap_ktls patches from this set.
- add a new helper connect_fd_to_addr_str.
v10:
- a new patch 10 is added.
- patches 1-6, 8-9 unchanged, only commit logs updated.
- "err = -errno" is used in patches 7, 11, 12 to get the real error number before checking value of "err".
v9:
- new patches 5-7, new struct member expect_errno for network_helper_opts.
- patches 1-4, 8-9 unchanged.
- update patches 10-11 to make sure all tests pass.
v8:
- only patch 8 updated, to fix errors reported by CI.
v7:
- address Martin's comments in v6. (thanks)
- use MAX(opts->backlog, 0) instead of opts->backlog.
- use connect_to_fd_opts instead connect_to_fd.
- more ASSERT_* to check errors.
v6:
- update patch 6 as Daniel suggested. (thanks)
v5:
- keep make_server and make_client as Eduard suggested.
v4:
- a new patch to use make_sockaddr in sockmap_ktls.
- a new patch to close fd in error path in drop_on_reuseport.
- drop make_server() in patch 7.
- drop make_client() too in patch 9.
v3:
- a new patch to add backlog for network_helper_opts.
- use start_server_str in sockmap_ktls now, not start_server.
v2:
- address Eduard's comments in v1. (thanks)
- fix errors reported by CI.
This patch set uses network helpers in sk_lookup, and drop the local helpers inetaddr_len() and make_socket().
Geliang Tang (9):
selftests/bpf: Add backlog for network_helper_opts selftests/bpf: Add ASSERT_OK_FD macro selftests/bpf: Close fd in error path in drop_on_reuseport selftests/bpf: Use start_server_str in sk_lookup selftests/bpf: Use start_server_addr in sk_lookup selftests/bpf: Use connect_fd_to_fd in sk_lookup selftests/bpf: Add connect_fd_to_addr_str helper selftests/bpf: Use connect_fd_to_addr_str in sk_lookup selftests/bpf: Drop make_socket in sk_lookup
tools/testing/selftests/bpf/network_helpers.c | 23 ++- tools/testing/selftests/bpf/network_helpers.h | 7 + .../selftests/bpf/prog_tests/sk_lookup.c | 156 ++++++------------ tools/testing/selftests/bpf/test_progs.h | 8 + 4 files changed, 92 insertions(+), 102 deletions(-)
Signature · 1 line
2.43.0