Skip to content

use network helpers, part 8

Geliang Tang bpf linux-kselftest 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest9 patches 4 repliesIn review 6 of 9 applied
  2. v1012 patches 4 repliesSuperseded
  3. v911 patches 1 replySuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v89 patches1 replySuperseded
v79 patches1 replySuperseded
v69 patches5 repliesSuperseded
v59 patches1 replySuperseded
v49 patches3 repliesSuperseded
v38 patches0 repliesSuperseded
v27 patches0 repliesSuperseded
v16 patches5 repliesSuperseded

Changes in v11 from the cover letter

- new patches 2, 4, 6.
- drop expect_errno from network_helper_opts as Eduard and Martin suggested.
- drop sockmap_ktls patches from this set.
- add a new helper connect_fd_to_addr_str.

Patches in v11 6 of 9 applied

#Subject and filesSizeRepliesApplied
1/9selftests/bpf: Add backlog for network_helper_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+5 -10 repliesApplied
2/9selftests/bpf: Add ASSERT_OK_FD macrotools/testing/selftests/bpf/test_progs.h+8 -01 replyApplied
3/9selftests/bpf: Close fd in error path in drop_on_reuseporttools/testing/selftests/bpf/prog_tests/sk_lookup.c+1 -11 replyApplied
4/9selftests/bpf: Use start_server_str in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+34 -240 repliesApplied
5/9selftests/bpf: Use start_server_addr in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+2 -80 repliesApplied
6/9selftests/bpf: Use connect_fd_to_fd in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+2 -91 replyApplied
7/9selftests/bpf: Add connect_fd_to_addr_str helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+24 -01 reply
8/9selftests/bpf: Use connect_fd_to_addr_str in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+8 -80 replies
9/9selftests/bpf: Drop make_socket in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+8 -510 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by.

PatchEduard Zingerman
1/9
2/9
3/9A-b
4/9A-b
5/9A-b
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH bpf-next v11 0/9] use network helpers, part 8

From: Geliang Tang <[email protected]>

v11:
- new patches 2, 4, 6.
- drop expect_errno from network_helper_opts as Eduard and Martin suggested.
- drop sockmap_ktls patches from this set.
- add a new helper connect_fd_to_addr_str.

v10:
- a new patch 10 is added.
- patches 1-6, 8-9 unchanged, only commit logs updated.
- "err = -errno" is used in patches 7, 11, 12 to get the real error number before checking value of "err".

v9:
- new patches 5-7, new struct member expect_errno for network_helper_opts.
- patches 1-4, 8-9 unchanged.
- update patches 10-11 to make sure all tests pass.

v8:
- only patch 8 updated, to fix errors reported by CI.

v7:
- address Martin's comments in v6. (thanks)
- use MAX(opts->backlog, 0) instead of opts->backlog.
- use connect_to_fd_opts instead connect_to_fd.
- more ASSERT_* to check errors.

v6:
- update patch 6 as Daniel suggested. (thanks)

v5:
- keep make_server and make_client as Eduard suggested.

v4:
- a new patch to use make_sockaddr in sockmap_ktls.
- a new patch to close fd in error path in drop_on_reuseport.
- drop make_server() in patch 7.
- drop make_client() too in patch 9.

v3:
- a new patch to add backlog for network_helper_opts.
- use start_server_str in sockmap_ktls now, not start_server.

v2:
- address Eduard's comments in v1. (thanks)
- fix errors reported by CI.

This patch set uses network helpers in sk_lookup, and drop the local helpers inetaddr_len() and make_socket().

Geliang Tang (9):
selftests/bpf: Add backlog for network_helper_opts selftests/bpf: Add ASSERT_OK_FD macro selftests/bpf: Close fd in error path in drop_on_reuseport selftests/bpf: Use start_server_str in sk_lookup selftests/bpf: Use start_server_addr in sk_lookup selftests/bpf: Use connect_fd_to_fd in sk_lookup selftests/bpf: Add connect_fd_to_addr_str helper selftests/bpf: Use connect_fd_to_addr_str in sk_lookup selftests/bpf: Drop make_socket in sk_lookup

 tools/testing/selftests/bpf/network_helpers.c |  23 ++-
 tools/testing/selftests/bpf/network_helpers.h |   7 +
 .../selftests/bpf/prog_tests/sk_lookup.c      | 156 ++++++------------
 tools/testing/selftests/bpf/test_progs.h      |   8 +
 4 files changed, 92 insertions(+), 102 deletions(-)
Signature · 1 line
2.43.0