Skip to content

power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug

Christophe JAILLET kernel-janitors linux-pm lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3power: supply: ab8500: Fix error handling when calling iio_read_channel_processed()drivers/power/supply/ab8500_charger.c+12 -42 replies
2/3power: supply: ab8500: Use iio_read_channel_processed_scale()drivers/power/supply/ab8500_charger.c+16 -122 replies
3/3power: supply: ab8500: Clean some error messagesdrivers/power/supply/ab8500_charger.c+4 -42 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronLinus Walleij
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug

This series is inspired by a patch submitted at [1].

While looking if the same pattern was relevant elsewhere, I ended in ab8500_charger.c.

Patch 1 fixes what looks to me as a regression introduced by 97ab78bac5d0.

Patch 2 is the initial goal of this series. That is to change some iio_read_channel_processed() + multiplication by a single, cleaner, iio_read_channel_processed_scale().

Patch 3 is a cosmetic change spotted while at it.

Honestly, I don't have a strong opinion if patch 2 helps in any way (explanation or confirmation would be appreciated for my own knowledge), but at least patch 1 deserves a look and seems value to me.

CJ

[1]: https://lore.kernel.org/all/[email protected]/

Christophe JAILLET (3):
power: supply: ab8500: Fix error handling when calling
iio_read_channel_processed()
power: supply: ab8500: Use iio_read_channel_processed_scale()
power: supply: ab8500: Clean some error messages

 drivers/power/supply/ab8500_charger.c | 52 ++++++++++++++++-----------
 1 file changed, 32 insertions(+), 20 deletions(-)
Signature · 1 line
2.45.2