Skip to content

mptcp: fix signal endpoint readd

Paolo Abeni mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v13 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- splitted the first 2 patches
- fixed accounting in mptcp_pm_remove_anno_addr
- self-tests depends on subflow_rebuild_header

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mptcp: fix user-space PM announced address accountingnet/mptcp/pm_netlink.c+13 -40 replies
2/4mptcp: fix NL PM announced address accountingnet/mptcp/pm_netlink.c+6 -40 replies
3/4selftests: mptcp: add explicit test case for remove/readdtools/testing/selftests/net/mptcp/mptcp_join.sh+29 -00 replies
4/4selftests: mptcp: fix error pathtools/testing/selftests/net/mptcp/mptcp_join.sh+1 -10 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthieu Baerts (NGI0)
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH mptcp-net v2 0/4] mptcp: fix signal endpoint readd

Issues/501 showed that the NL PM currently don't add corectly removal and re-add of signal endpoint.

Patches 1 and 2 addresses the issue, patch 3/4 introduce a related self-test, and the last patch address a pre-existing buglet in the self-test infra.

v1 -> v2:
- splitted the first 2 patches
- fixed accounting in mptcp_pm_remove_anno_addr
- self-tests depends on subflow_rebuild_header

Paolo Abeni (4):
mptcp: fix user-space PM announced address accounting
mptcp: fix NL PM announced address accounting
selftests: mptcp: add explicit test case for remove/readd
selftests: mptcp: fix error path

 net/mptcp/pm_netlink.c                        | 27 +++++++++++-----
 .../testing/selftests/net/mptcp/mptcp_join.sh | 31 ++++++++++++++++++-
 2 files changed, 49 insertions(+), 9 deletions(-)
Signature · 1 line
2.45.2