Skip to content

virtio-balloon: make it spec compliant

Michael S. Tsirkin kvm linux-mm linux-remoteproc linux-s390 linux-um lkml llvm oe-kbuild-all virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 11 repliesIn review
  2. v12 patches 12 repliesSuperseded

Changes in v2 from the cover letter

rebased on vhost tip

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio_balloon: add work around for out of spec QEMUdrivers/virtio/virtio_balloon.c+17 -20 replies
2/2virtio: fix vq # for balloonarch/um/drivers/virtio_uml.c drivers/remoteproc/remoteproc_virtio.c drivers/s390/virtio/virtio_ccw.c +3 more+18 -139 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMathieu PoirierHalil Pasic
1/2
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] virtio-balloon: make it spec compliant

Currently, if VIRTIO_BALLOON_F_FREE_PAGE_HINT is off but VIRTIO_BALLOON_F_REPORTING is on, then the reporting vq gets number 3 while spec says it's number 4.
It happens to work because the qemu virtio pci driver is *also* out of spec.

To fix:
1. add vq4 as per spec
2. to help out the buggy qemu driver, if finding vqs fail, try with vq3 as reporting.

Fixes b0c504f15471 ("virtio-balloon: add support for providing free page reports to host")
Cc "Alexander Duyck" <[email protected]>

Changes from v1:
rebased on vhost tip

Michael S. Tsirkin (2):
virtio_balloon: add work around for out of spec QEMU
virtio: fix vq # for balloon

 arch/um/drivers/virtio_uml.c           |  4 ++--
 drivers/remoteproc/remoteproc_virtio.c |  4 ++--
 drivers/s390/virtio/virtio_ccw.c       |  4 ++--
 drivers/virtio/virtio_balloon.c        | 19 +++++++++++++++++--
 drivers/virtio/virtio_mmio.c           |  4 ++--
 drivers/virtio/virtio_pci_common.c     | 11 ++++++++---
 drivers/virtio/virtio_vdpa.c           |  4 ++--
 7 files changed, 35 insertions(+), 15 deletions(-)
Signature · 1 line
MST