Skip to content

net: stmmac: refactor FPE for gmac4 and xgmac

Furong Xu linux-arm-kernel lkml netdev 1 version NAK

Status from this message: NACK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/7net: stmmac: xgmac: drop incomplete FPE implementationdrivers/net/ethernet/stmicro/stmmac/dwxgmac2.h drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c+0 -295 replies
2/7net: stmmac: gmac4: drop FPE implementation for refactoringdrivers/net/ethernet/stmicro/stmmac/dwmac4_core.c drivers/net/ethernet/stmicro/stmmac/dwmac5.c drivers/net/ethernet/stmicro/stmmac/dwmac5.h+0 -881 reply
3/7net: stmmac: refactor Frame Preemption(FPE) implementationdrivers/net/ethernet/stmicro/stmmac/Makefile drivers/net/ethernet/stmicro/stmmac/common.h drivers/net/ethernet/stmicro/stmmac/hwif.c +3 more+42 -140 replies
4/7net: stmmac: gmac4: complete FPE supportdrivers/net/ethernet/stmicro/stmmac/hwif.c drivers/net/ethernet/stmicro/stmmac/hwif.h drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c +1 more+90 -00 replies
5/7net: stmmac: xgmac: rename XGMAC_RQ to XGMAC_FPRQdrivers/net/ethernet/stmicro/stmmac/dwxgmac2.h+2 -20 replies
6/7net: stmmac: xgmac: complete FPE supportdrivers/net/ethernet/stmicro/stmmac/hwif.c drivers/net/ethernet/stmicro/stmmac/hwif.h drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c +1 more+41 -00 replies
7/7net: stmmac: xgmac: enable Frame Preemption Interrupt by defaultdrivers/net/ethernet/stmicro/stmmac/dwxgmac2.h+2 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next v1 0/7] net: stmmac: refactor FPE for gmac4 and xgmac

Refactor FPE implementation by moving common code for DWMAC4 and DWXGMAC into a separate FPE module.

FPE implementation for DWMAC4 and DWXGMAC differs only for:
1) Offset address of MAC_FPE_CTRL_STS
2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1

Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a

Furong Xu (7):
net: stmmac: xgmac: drop incomplete FPE implementation
net: stmmac: gmac4: drop FPE implementation for refactoring
net: stmmac: refactor Frame Preemption(FPE) implementation
net: stmmac: gmac4: complete FPE support
net: stmmac: xgmac: rename XGMAC_RQ to XGMAC_FPRQ
net: stmmac: xgmac: complete FPE support
net: stmmac: xgmac: enable Frame Preemption Interrupt by default

 drivers/net/ethernet/stmicro/stmmac/Makefile  |   2 +-
 drivers/net/ethernet/stmicro/stmmac/common.h  |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac4_core.c |   6 -
 drivers/net/ethernet/stmicro/stmmac/dwmac5.c  |  66 ---------
 drivers/net/ethernet/stmicro/stmmac/dwmac5.h  |  16 ---
 .../net/ethernet/stmicro/stmmac/dwxgmac2.h    |   9 +-
 .../ethernet/stmicro/stmmac/dwxgmac2_core.c   |  27 ----
 drivers/net/ethernet/stmicro/stmmac/hwif.c    |   7 +
 drivers/net/ethernet/stmicro/stmmac/hwif.h    |  30 ++--
 .../net/ethernet/stmicro/stmmac/stmmac_fpe.c  | 131 ++++++++++++++++++
 .../net/ethernet/stmicro/stmmac/stmmac_fpe.h  |  16 +++
 11 files changed, 177 insertions(+), 134 deletions(-)
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
Signature · 1 line
2.34.1