Skip to content

clk: renesas: rcar-gen4: Fractional PLL improvements

Geert Uytterhoeven linux-clk linux-renesas-soc 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 0 repliesNew
  2. v114 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Add Reviewed-by,
- Sort register definitions by register offset,
- Use mul_u64_u32_shr() and div64_ul() helpers,
- New patch "PATCH v2 15/15] clk: renesas: rcar-gen4: Remove unused

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15clk: renesas: rcar-gen4: Removed unused SSMODE_* definitionsdrivers/clk/renesas/rcar-gen4-cpg.c+0 -40 replies
2/15clk: renesas: rcar-gen4: Clarify custom PLL clock supportdrivers/clk/renesas/rcar-gen4-cpg.c+17 -150 replies
3/15clk: renesas: rcar-gen4: Use FIELD_GET()drivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+11 -50 replies
4/15clk: renesas: rcar-gen4: Use defines for common CPG registersdrivers/clk/renesas/r8a779a0-cpg-mssr.c drivers/clk/renesas/r8a779f0-cpg-mssr.c drivers/clk/renesas/r8a779g0-cpg-mssr.c +2 more+27 -210 replies
5/15clk: renesas: rcar-gen4: Add support for fractional multiplicationdrivers/clk/renesas/rcar-gen4-cpg.c+55 -160 replies
6/15clk: renesas: rcar-gen4: Add support for variable fractional PLLsdrivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+18 -70 replies
7/15clk: renesas: rcar-gen4: Add support for fixed variable PLLsdrivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+26 -100 replies
8/15clk: renesas: rcar-gen4: Add support for fractional 9.24 PLLsdrivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+44 -00 replies
9/15clk: renesas: r8a779a0: Use defines for PLL control registersdrivers/clk/renesas/r8a779a0-cpg-mssr.c+9 -40 replies
10/15clk: renesas: r8a779f0: Model PLL1/2/3/6 as fractional PLLsdrivers/clk/renesas/r8a779f0-cpg-mssr.c+6 -60 replies
11/15clk: renesas: r8a779g0: Model PLL1/3/4/6 as fractional PLLsdrivers/clk/renesas/r8a779g0-cpg-mssr.c+7 -70 replies
12/15clk: renesas: r8a779h0: Model PLL1/2/3/4/6 as fractional PLLsdrivers/clk/renesas/r8a779h0-cpg-mssr.c+5 -50 replies
13/15clk: renesas: rcar-gen4: Remove unused variable PLL2 clock typedrivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+0 -100 replies
14/15clk: renesas: rcar-gen4: Remove unused fixed PLL clock typesdrivers/clk/renesas/rcar-gen4-cpg.c drivers/clk/renesas/rcar-gen4-cpg.h+0 -240 replies
15/15clk: renesas: rcar-gen4: Remove unused default PLL2/3/4/6 configsdrivers/clk/renesas/r8a779a0-cpg-mssr.c drivers/clk/renesas/r8a779f0-cpg-mssr.c drivers/clk/renesas/r8a779g0-cpg-mssr.c +2 more+20 -280 replies

Reviews trailers per patch

14 of 15 patches have a Reviewed-by or Acked-by.

PatchYoshihiro Shimoda
1/15R-b
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15R-b
14/15R-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/15] clk: renesas: rcar-gen4: Fractional PLL improvements

Hi all,

Currently, almost all PLLs on R-Car Gen4 SoCs are modelled as fixed divider clocks, based on the state of the mode pins. The only exception is PLL2 on R-Car V4H, which uses a custom clock driver to support High Performance mode on the Cortex-A76 CPU cores.

However, the boot loader stack may have changed the actual PLL configuration from the default, leading to incorrect clock frequencies. A typical sympton is a CPU core running much slower than reported by Linux.

This patch series enhances PLL support on R-Car Gen4 support by obtaining the actual PLL configuration from the hardware. As these PLLs can be configured for fractional multiplication, an old patch to add support fractional multiplication is revived, too. Of course some cleanups are included, too.

Changes compared to v1:
- Add Reviewed-by,
- Sort register definitions by register offset,
- Use mul_u64_u32_shr() and div64_ul() helpers,
- New patch "PATCH v2 15/15] clk: renesas: rcar-gen4: Remove unused

    default PLL2/3/4/6 configs".

I plan to queue this series in renesas-clk-for-v6.12.

Thanks for your comments!

Geert Uytterhoeven (15):
clk: renesas: rcar-gen4: Removed unused SSMODE_* definitions
clk: renesas: rcar-gen4: Clarify custom PLL clock support
clk: renesas: rcar-gen4: Use FIELD_GET()
clk: renesas: rcar-gen4: Use defines for common CPG registers
clk: renesas: rcar-gen4: Add support for fractional multiplication
clk: renesas: rcar-gen4: Add support for variable fractional PLLs
clk: renesas: rcar-gen4: Add support for fixed variable PLLs
clk: renesas: rcar-gen4: Add support for fractional 9.24 PLLs
clk: renesas: r8a779a0: Use defines for PLL control registers
clk: renesas: r8a779f0: Model PLL1/2/3/6 as fractional PLLs
clk: renesas: r8a779g0: Model PLL1/3/4/6 as fractional PLLs
clk: renesas: r8a779h0: Model PLL1/2/3/4/6 as fractional PLLs
clk: renesas: rcar-gen4: Remove unused variable PLL2 clock type
clk: renesas: rcar-gen4: Remove unused fixed PLL clock types
clk: renesas: rcar-gen4: Remove unused default PLL2/3/4/6 configs

 drivers/clk/renesas/r8a779a0-cpg-mssr.c |  35 ++--
 drivers/clk/renesas/r8a779f0-cpg-mssr.c |  28 ++--
 drivers/clk/renesas/r8a779g0-cpg-mssr.c |  36 ++--
 drivers/clk/renesas/r8a779h0-cpg-mssr.c |  32 ++--
 drivers/clk/renesas/rcar-gen4-cpg.c     | 210 ++++++++++++++++--------
 drivers/clk/renesas/rcar-gen4-cpg.h     |  36 ++--
 6 files changed, 230 insertions(+), 147 deletions(-)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds