Skip to content

use network helpers, part 9

Geliang Tang bpf linux-kselftest 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v25 patches 1 replySuperseded
  3. v15 patches 1 replySuperseded

Changes in v3 from the cover letter

- patch 2:
- clear errno before connect_to_fd_opts.
- print err logs in run_test.
- set err to -1 when fd >= 0.
- patch 3:
- drop "int err".

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5selftests/bpf: Drop type of connect_to_fd_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c +1 more+15 -140 replies
2/5selftests/bpf: Drop must_fail from network_helper_optstools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h tools/testing/selftests/bpf/prog_tests/cgroup_v1v2.c+10 -361 reply
3/5selftests/bpf: Add connect_to_addr_str helpertools/testing/selftests/bpf/network_helpers.c tools/testing/selftests/bpf/network_helpers.h+17 -00 replies
4/5selftests/bpf: Use connect_to_addr_str in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+10 -161 reply
5/5selftests/bpf: Drop make_socket in sk_lookuptools/testing/selftests/bpf/prog_tests/sk_lookup.c+6 -521 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/5] use network helpers, part 9

From: Geliang Tang <[email protected]>

v3:
- patch 2:
- clear errno before connect_to_fd_opts.
- print err logs in run_test.
- set err to -1 when fd >= 0.
- patch 3:
- drop "int err".

v2:
- update patch 2 as Martin suggested.

This is the 9th part of series "use network helpers" all BPF selftests wide.

Patches 1-2 update network helpers interfaces suggested by Martin. Patch 3 adds a new helper connect_to_addr_str() as Martin suggested instead of adding connect_fd_to_addr_str().
Patch 4 uses this newly added helper in make_client(). Patch 5 uses make_client() in sk_lookup and drop make_socket().

Geliang Tang (5):
selftests/bpf: Drop type of connect_to_fd_opts selftests/bpf: Drop must_fail from network_helper_opts selftests/bpf: Add connect_to_addr_str helper selftests/bpf: Use connect_to_addr_str in sk_lookup selftests/bpf: Drop make_socket in sk_lookup

 tools/testing/selftests/bpf/network_helpers.c | 65 ++++++--------
 tools/testing/selftests/bpf/network_helpers.h |  5 +-
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |  2 +-
 .../selftests/bpf/prog_tests/cgroup_v1v2.c    | 16 ++--
 .../selftests/bpf/prog_tests/sk_lookup.c      | 84 ++++---------------
 5 files changed, 56 insertions(+), 116 deletions(-)
Signature · 1 line
2.43.0