Skip to content

Add ACPI CPER firmware first error injection on ARM emulation

Mauro Carvalho Chehab kvm lkml qemu-arm qemu-devel 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest21 patches 18 repliesIn review
  2. v912 patches 16 repliesSuperseded
  3. v813 patches 20 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v710 patches9 repliesSuperseded
v610 patches12 repliesSuperseded
v57 patches46 repliesSuperseded
v4 posting 2/27 patches1 replySuperseded
v4 posting 1/26 patches9 repliesSuperseded
v37 patches34 repliesSuperseded
v27 patches2 repliesSuperseded
v16 patches2 repliesSuperseded

Changes in v10 from the cover letter

- Patch 1 split on several patches to make reviews easier;
- Added a migration patch;
- CPER QMP command was renamed;
- Updated some comments to better reflect exact ACPI version;
- Removed a code to reset acks when OSPM fails to read records;
- Removed a duplicated config GHES_CPER symbol;
- There is now an arch-independent namespace for GHES source IDs;
- Fixed the size of hest_ghes_notify array when creating tables;
- acpi-hest.json is now a section of ACPI;
- QMP command renamed from @ghes-cper to inject-ghes-error.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21acpi/ghes: add a firmware file with HEST addresshw/acpi/ghes.c include/hw/acpi/ghes.h+16 -01 reply
2/21acpi/generic_event_device: Update GHES migration to cover hest addrhw/acpi/generic_event_device.c+6 -55 replies
3/21acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVEDhw/acpi/ghes.c include/hw/acpi/ghes.h+4 -61 reply
4/21acpi/ghes: simplify acpi_ghes_record_errors() codehw/acpi/ghes.c+29 -271 reply
5/21acpi/ghes: better handle source_id and notificationhw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+20 -221 reply
6/21acpi/ghes: Remove a duplicated out of bounds checkhw/acpi/ghes.c+1 -31 reply
7/21acpi/ghes: rework the logic to handle HEST source IDhw/acpi/ghes.c include/hw/acpi/ghes.h+73 -283 replies
8/21acpi/ghes: Change the type for source_idhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h+3 -31 reply
9/21acpi/ghes: Don't hardcode the number of sources on gheshw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+49 -300 replies
10/21acpi/ghes: make the GHES record generation more generichw/acpi/ghes.c+63 -380 replies
11/21acpi/ghes: don't crash QEMU if ghes GED is not foundhw/acpi/ghes.c+4 -10 replies
12/21acpi/ghes: rename etc/hardware_error file macroshw/acpi/ghes.c+19 -130 replies
13/21acpi/ghes: better name GHES memory error functionhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h +1 more+6 -50 replies
14/21acpi/ghes: add a notifier to notify when error data is readyhw/acpi/ghes.c include/hw/acpi/ghes.h+8 -00 replies
15/21acpi/generic_event_device: add an APEI error devicehw/acpi/aml-build.c hw/acpi/generic_event_device.c include/hw/acpi/acpi_dev_interface.h +2 more+22 -00 replies
16/21arm/virt: Wire up a GED error device for ACPI / GHEShw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+13 -10 replies
17/21qapi/acpi-hest: add an interface to do generic CPER error injectionMAINTAINERS hw/acpi/Kconfig hw/acpi/ghes.c +10 more+113 -10 replies
18/21docs: acpi_hest_ghes: fix documentation for CPER sizedocs/specs/acpi_hest_ghes.rst+4 -20 replies
19/21scripts/ghes_inject: add a script to generate GHES error injectMAINTAINERS scripts/arm_processor_error.py scripts/ghes_inject.py +1 more+1133 -00 replies
20/21target/arm: add an experimental mpidr arm cpu property objecttarget/arm/cpu.c target/arm/cpu.h target/arm/helper.c+10 -20 replies
21/21scripts/arm_processor_error.py: retrieve mpidr if not filledscripts/arm_processor_error.py+19 -80 replies

Reviews trailers per patch

9 of 21 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovJonathan CameronShiju JoseMauro Carvalho Chehab
1/21R-b
2/21
3/21R-b
4/21R-b
5/21
6/21R-b
7/21
8/21
9/21
10/21
11/21
12/21R-b
13/21R-b
14/21
15/21R-b Co-authored-by Co-authored-by
16/21A-b Co-authored-by Co-authored-by
17/21Co-authored-by Co-authored-by Co-authored-by
18/21A-b
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH v10 00/21] Add ACPI CPER firmware first error injection on ARM emulation

This series add support for injecting generic CPER records. Such records are generated outside QEMU via a provided script.

On this version, the patch reworking the way offsets are calculated were split on several other patches, to make one logical change per patch and make review easier.

Despite the number of patches increased from 12 to 21, there is just one real new patch (as the other ones are a split from a big change):

acpi/generic_event_device: Update GHES migration to cover hest addr

---

v10:
- Patch 1 split on several patches to make reviews easier;
- Added a migration patch;
- CPER QMP command was renamed;
- Updated some comments to better reflect exact ACPI version;
- Removed a code to reset acks when OSPM fails to read records;
- Removed a duplicated config GHES_CPER symbol;
- There is now an arch-independent namespace for GHES source IDs;
- Fixed the size of hest_ghes_notify array when creating tables;
- acpi-hest.json is now a section of ACPI;
- QMP command renamed from @ghes-cper to inject-ghes-error.

v9:
- Patches reorganized to make easier for reviewers;
- source ID is now guest-OS specific;
- Some patches got a revision history since v8;
- Several minor cleanups.

v8:
- Fix one of the BIOS links that were incorrect;
- Changed mem error internal injection to use a common code;
- No more hardcoded values for CPER: instead of using just the payload at the QAPI, it now has the full raw CPER there;
- Error injection script now supports changing fields at the Generic Error Data section of the CPER;
- Several minor cleanups.

v7:
- Change the way offsets are calculated and used on HEST table. Now, it is compatible with migrations as all offsets are relative to the HEST table;
- GHES interface is now more generic: the entire CPER is sent via QMP, instead of just the payload;
- Some code cleanups to make the code more robust;
- The python script now uses QEMUMonitorProtocol class.

v6:
- PNP0C33 device creation moved to aml-build.c;
- acpi_ghes record functions now use ACPI notify parameter, instead of source ID;
- the number of source IDs is now automatically calculated;
- some code cleanups and function/var renames;
- some fixes and cleanups at the error injection script;
- ghes cper stub now produces an error if cper JSON is not compiled;
- Offset calculation logic for GHES was refactored;
- Updated documentation to reflect the GHES allocated size;
- Added a x-mpidr object for QOM usage;
- Added a patch making usage of x-mpidr field at ARM injection script;

v5:
- CPER guid is now passing as string;
- raw-data is now passed with base64 encode;
- Removed several GPIO left-overs from arm/virt.c changes;
- Lots of cleanups and improvements at the error injection script. It now better handles QMP dialog and doesn't print debug messages. Also, code was split on two modules, to make easier to add more error injection commands.

v4:
- CPER generation moved to happen outside QEMU;
- One patch adding support for mpidr query was removed.

v3:
- patch 1 cleanups with some comment changes and adding another place where the poweroff GPIO define should be used. No changes on other patches (except due to conflict resolution).

v2:
- added a new patch using a define for GPIO power pin;
- patch 2 changed to also use a define for generic error GPIO pin;
- a couple cleanups at patch 2 removing uneeded else clauses.

Example of generating a CPER record:

$ scripts/ghes_inject.py -d arm -p 0xdeadbeef
GUID: e19e3d16-bc11-11e4-9caa-c2051d5d46b0
Generic Error Status Block (20 bytes):
      00000000  01 00 00 00 00 00 00 00 00 00 00 00 90 00 00 00   ................
      00000010  00 00 00 00                                       ....

Generic Error Data Entry (72 bytes):

      00000000  16 3d 9e e1 11 bc e4 11 9c aa c2 05 1d 5d 46 b0   .=...........]F.
      00000010  00 00 00 00 00 03 00 00 48 00 00 00 00 00 00 00   ........H.......
      00000020  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ................
      00000030  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00   ................
      00000040  00 00 00 00 00 00 00 00                           ........

Payload (72 bytes):

      00000000  05 00 00 00 01 00 00 00 48 00 00 00 00 00 00 00   ........H.......
      00000010  00 00 00 80 00 00 00 00 10 05 0f 00 00 00 00 00   ................
      00000020  00 00 00 00 00 00 00 00 00 20 14 00 02 01 00 03   ......... ......
      00000030  0f 00 91 00 00 00 00 00 ef be ad de 00 00 00 00   ................
      00000040  ef be ad de 00 00 00 00                           ........

Error injected.

[    9.358364] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
[    9.359027] {1}[Hardware Error]: event severity: recoverable
[    9.359586] {1}[Hardware Error]:  Error 0, type: recoverable
[    9.360124] {1}[Hardware Error]:   section_type: ARM processor error
[    9.360561] {1}[Hardware Error]:   MIDR: 0x00000000000f0510
[    9.361160] {1}[Hardware Error]:   Multiprocessor Affinity Register (MPIDR): 0x0000000080000000
[    9.361643] {1}[Hardware Error]:   running state: 0x0
[    9.362142] {1}[Hardware Error]:   Power State Coordination Interface state: 0
[    9.362682] {1}[Hardware Error]:   Error info structure 0:
[    9.363030] {1}[Hardware Error]:   num errors: 2
[    9.363656] {1}[Hardware Error]:    error_type: 0x02: cache error
[    9.364163] {1}[Hardware Error]:    error_info: 0x000000000091000f
[    9.364834] {1}[Hardware Error]:     transaction type: Data Access
[    9.365599] {1}[Hardware Error]:     cache error, operation type: Data write
[    9.366441] {1}[Hardware Error]:     cache level: 2
[    9.367005] {1}[Hardware Error]:     processor context not corrupted
[    9.367753] {1}[Hardware Error]:    physical fault address: 0x00000000deadbeef
[    9.374267] Memory failure: 0xdeadb: recovery action for free buddy page: Recovered

Such script currently supports arm processor error CPER, but can easily be extended to other GHES notification types.

Mauro Carvalho Chehab (21):
acpi/ghes: add a firmware file with HEST address acpi/generic_event_device: Update GHES migration to cover hest addr acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED acpi/ghes: simplify acpi_ghes_record_errors() code acpi/ghes: better handle source_id and notification acpi/ghes: Remove a duplicated out of bounds check acpi/ghes: rework the logic to handle HEST source ID acpi/ghes: Change the type for source_id
acpi/ghes: Don't hardcode the number of sources on ghes acpi/ghes: make the GHES record generation more generic acpi/ghes: don't crash QEMU if ghes GED is not found acpi/ghes: rename etc/hardware_error file macros acpi/ghes: better name GHES memory error function acpi/ghes: add a notifier to notify when error data is ready acpi/generic_event_device: add an APEI error device arm/virt: Wire up a GED error device for ACPI / GHES qapi/acpi-hest: add an interface to do generic CPER error injection
docs: acpi_hest_ghes: fix documentation for CPER size scripts/ghes_inject: add a script to generate GHES error inject target/arm: add an experimental mpidr arm cpu property object scripts/arm_processor_error.py: retrieve mpidr if not filled

 MAINTAINERS                            |  10 +
 docs/specs/acpi_hest_ghes.rst          |   6 +-
 hw/acpi/Kconfig                        |   5 +
 hw/acpi/aml-build.c                    |  10 +
 hw/acpi/generic_event_device.c         |  19 +-
 hw/acpi/ghes-stub.c                    |   2 +-
 hw/acpi/ghes.c                         | 312 +++++++----
 hw/acpi/ghes_cper.c                    |  32 ++
 hw/acpi/ghes_cper_stub.c               |  19 +
 hw/acpi/meson.build                    |   2 +
 hw/arm/virt-acpi-build.c               |  12 +-
 hw/arm/virt.c                          |  19 +-
 include/hw/acpi/acpi_dev_interface.h   |   1 +
 include/hw/acpi/aml-build.h            |   2 +
 include/hw/acpi/generic_event_device.h |   1 +
 include/hw/acpi/ghes.h                 |  37 +-
 include/hw/arm/virt.h                  |   2 +
 qapi/acpi-hest.json                    |  35 ++
 qapi/meson.build                       |   1 +
 qapi/qapi-schema.json                  |   1 +
 scripts/arm_processor_error.py         | 388 ++++++++++++++
 scripts/ghes_inject.py                 |  51 ++
 scripts/qmp_helper.py                  | 702 +++++++++++++++++++++++++
 target/arm/cpu.c                       |   1 +
 target/arm/cpu.h                       |   1 +
 target/arm/helper.c                    |  10 +-
 target/arm/kvm.c                       |   3 +-
 27 files changed, 1552 insertions(+), 132 deletions(-)
 create mode 100644 hw/acpi/ghes_cper.c
 create mode 100644 hw/acpi/ghes_cper_stub.c
 create mode 100644 qapi/acpi-hest.json
 create mode 100644 scripts/arm_processor_error.py
 create mode 100755 scripts/ghes_inject.py
 create mode 100644 scripts/qmp_helper.py
Signature · 1 line
2.46.0