Skip to content

selftests/bpf: Improve libc portability / musl support (part 1)

Tony Ambardar bpf linux-kselftest 1 version Applied

Status from this message: Applied to bpf-next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 11 repliesApplied 17/19

Patches in v1 Applied · 17/19

#Subject and filesSizeRepliesApplied
1/19selftests/bpf: Use pid_t consistently in test_progs.ctools/testing/selftests/bpf/test_progs.c+1 -11 replyApplied
2/19selftests/bpf: Fix compile error from rlim_t in sk_storage_map.ctools/testing/selftests/bpf/map_tests/sk_storage_map.c+1 -10 repliesApplied
3/19selftests/bpf: Fix error compiling bpf_iter_setsockopt.c with musl libctools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c+1 -11 replyApplied
4/19selftests/bpf: Drop unneeded include in unpriv_helpers.ctools/testing/selftests/bpf/unpriv_helpers.c+0 -10 repliesApplied
5/19selftests/bpf: Drop unneeded include in sk_lookup.ctools/testing/selftests/bpf/prog_tests/sk_lookup.c+0 -10 replies
6/19selftests/bpf: Drop unneeded include in flow_dissector.ctools/testing/selftests/bpf/prog_tests/flow_dissector.c+0 -10 replies
7/19selftests/bpf: Fix missing ARRAY_SIZE() definition in bench.ctools/testing/selftests/bpf/bench.c+1 -02 repliesApplied
8/19selftests/bpf: Fix missing UINT_MAX definitions in benchmarkstools/testing/selftests/bpf/bench.h+1 -00 repliesApplied
9/19selftests/bpf: Fix missing BUILD_BUG_ON() declarationtools/testing/selftests/bpf/prog_tests/user_ringbuf.c+1 -00 repliesApplied
10/19selftests/bpf: Fix include of <sys/fcntl.h>tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c+1 -10 repliesApplied
11/19selftests/bpf: Fix compiling parse_tcp_hdr_opt.c with musl-libctools/testing/selftests/bpf/prog_tests/parse_tcp_hdr_opt.c+1 -00 repliesApplied
12/19selftests/bpf: Fix compiling kfree_skb.c with musl-libctools/testing/selftests/bpf/prog_tests/kfree_skb.c+1 -00 repliesApplied
13/19selftests/bpf: Fix compiling flow_dissector.c with musl-libctools/testing/selftests/bpf/prog_tests/flow_dissector.c+1 -00 repliesApplied
14/19selftests/bpf: Fix compiling tcp_rtt.c with musl-libctools/testing/selftests/bpf/prog_tests/tcp_rtt.c+1 -00 repliesApplied
15/19selftests/bpf: Fix compiling core_reloc.c with musl-libctools/testing/selftests/bpf/prog_tests/core_reloc.c+1 -00 repliesApplied
16/19selftests/bpf: Fix errors compiling lwt_redirect.c with musl libctools/testing/selftests/bpf/prog_tests/lwt_redirect.c+0 -10 repliesApplied
17/19selftests/bpf: Fix errors compiling decap_sanity.c with musl libctools/testing/selftests/bpf/prog_tests/decap_sanity.c+0 -10 repliesApplied
18/19selftests/bpf: Fix errors compiling crypto_sanity.c with musl libctools/testing/selftests/bpf/prog_tests/crypto_sanity.c+0 -11 replyApplied
19/19selftests/bpf: Fix errors compiling cg_storage_multi.h with musl libctools/testing/selftests/bpf/progs/cg_storage_multi.h+0 -23 repliesApplied

Reviews trailers per patch

3 of 19 patches have a Reviewed-by or Acked-by.

PatchVadim FedorenkoGeliang Tang
1/19A-b
2/19
3/19A-b
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19R-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next v1 00/19] selftests/bpf: Improve libc portability / musl support (part 1)

Hello all,

This series includes the bulk of libc-related compile fixes accumulated to support systems using musl, with smaller numbers to follow. These patches are simple and straightforward, and the series has been tested with the kernel-patches/bpf CI and locally using mips64el-gcc/musl-libc and QEMU with an OpenWrt rootfs.

The patches address a few general categories of libc portability issues:

- missing, redundant or incorrect include headers
- disabled GNU header extensions (i.e. missing #define _GNU_SOURCE)
- issues with types and casting

Feedback and suggestions for improvement are welcome!

Thanks,
Tony

Tony Ambardar (19):
selftests/bpf: Use pid_t consistently in test_progs.c selftests/bpf: Fix compile error from rlim_t in sk_storage_map.c selftests/bpf: Fix error compiling bpf_iter_setsockopt.c with musl
libc
selftests/bpf: Drop unneeded include in unpriv_helpers.c selftests/bpf: Drop unneeded include in sk_lookup.c selftests/bpf: Drop unneeded include in flow_dissector.c selftests/bpf: Fix missing ARRAY_SIZE() definition in bench.c selftests/bpf: Fix missing UINT_MAX definitions in benchmarks selftests/bpf: Fix missing BUILD_BUG_ON() declaration selftests/bpf: Fix include of <sys/fcntl.h>
selftests/bpf: Fix compiling parse_tcp_hdr_opt.c with musl-libc selftests/bpf: Fix compiling kfree_skb.c with musl-libc selftests/bpf: Fix compiling flow_dissector.c with musl-libc selftests/bpf: Fix compiling tcp_rtt.c with musl-libc selftests/bpf: Fix compiling core_reloc.c with musl-libc selftests/bpf: Fix errors compiling lwt_redirect.c with musl libc selftests/bpf: Fix errors compiling decap_sanity.c with musl libc selftests/bpf: Fix errors compiling crypto_sanity.c with musl libc selftests/bpf: Fix errors compiling cg_storage_multi.h with musl libc

 tools/testing/selftests/bpf/bench.c                          | 1 +
 tools/testing/selftests/bpf/bench.h                          | 1 +
 tools/testing/selftests/bpf/map_tests/sk_storage_map.c       | 2 +-
 tools/testing/selftests/bpf/prog_tests/bpf_iter_setsockopt.c | 2 +-
 tools/testing/selftests/bpf/prog_tests/core_reloc.c          | 1 +
 tools/testing/selftests/bpf/prog_tests/crypto_sanity.c       | 1 -
 tools/testing/selftests/bpf/prog_tests/decap_sanity.c        | 1 -
 tools/testing/selftests/bpf/prog_tests/flow_dissector.c      | 2 +-
 tools/testing/selftests/bpf/prog_tests/kfree_skb.c           | 1 +
 tools/testing/selftests/bpf/prog_tests/lwt_redirect.c        | 1 -
 tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c | 2 +-
 tools/testing/selftests/bpf/prog_tests/parse_tcp_hdr_opt.c   | 1 +
 tools/testing/selftests/bpf/prog_tests/sk_lookup.c           | 1 -
 tools/testing/selftests/bpf/prog_tests/tcp_rtt.c             | 1 +
 tools/testing/selftests/bpf/prog_tests/user_ringbuf.c        | 1 +
 tools/testing/selftests/bpf/progs/cg_storage_multi.h         | 2 --
 tools/testing/selftests/bpf/test_progs.c                     | 2 +-
 tools/testing/selftests/bpf/unpriv_helpers.c                 | 1 -
 18 files changed, 12 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1