Skip to content

btrfs: fixes for buffered write qgroup rsv leaks

Boris Burkov linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: implement launder_folio for clearing dirty page rsvfs/btrfs/inode.c+6 -01 reply
2/2btrfs: fix qgroup rsv leaks in cow_file_rangefs/btrfs/inode.c+3 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: fixes for buffered write qgroup rsv leaks

generic/475 exposes qgroup rsv leaks under EIO errors. These are fixes for two classes of buffered write errors we are still hitting:
1. dirty pages leaked during an aborted transaction
2. dirty pages getting un-dirtied and leaked by cow_file_range when it doesn't make an ordered extent for a range.

After these two fixes, I was able to run generic/475 with squota enabled at mkfs 100 times in a row without an error, and a modified generic/475 that always sleeps for 0 seconds 500 times.

Boris Burkov (2):
btrfs: implement launder_folio for clearing dirty page rsv
btrfs: fix qgroup rsv leaks in cow_file_range

 fs/btrfs/inode.c | 9 +++++++++
 1 file changed, 9 insertions(+)
Signature · 1 line
2.45.2