Skip to content

Input: spear-keyboard - Fix an issue and clean-up code

Christophe JAILLET kernel-janitors linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Input: spear-keyboard - Fix a double put in spear_kbd_remove()drivers/input/keyboard/spear-keyboard.c+0 -13 replies
2/2Input: spear-keyboard - Switch to devm_clk_get_prepared()drivers/input/keyboard/spear-keyboard.c+1 -141 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Input: spear-keyboard - Fix an issue and clean-up code

Patch 1 fixes an old double put issue in the remove function.

Patch 2 is just a clean up to remove some lines of code. It changes the order of some initialization so should be reviewed with care. This driver looks old, without changes other than clean-up for more than 10 years, so maybe this patch should just be dropped.
I let you decide if safe and useful or not.

Both patch are compile tested only.

Christophe JAILLET (2):
Input: spear-keyboard - Fix a double put in spear_kbd_remove()
Input: spear-keyboard - Switch to devm_clk_get_prepared()

 drivers/input/keyboard/spear-keyboard.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)
Signature · 1 line
2.45.2