Skip to content

btrfs: convert most of the data path to use folios

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest46 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/46btrfs: convert btrfs_readahead to only use foliofs/btrfs/extent_io.c+8 -280 replies
2/46btrfs: convert btrfs_read_folio to only use a foliofs/btrfs/extent_io.c+4 -50 replies
3/46btrfs: convert end_page_read to take a foliofs/btrfs/extent_io.c+20 -190 replies
4/46btrfs: convert begin_page_folio to take a folio insteadfs/btrfs/extent_io.c+3 -50 replies
5/46btrfs: convert submit_extent_page to use a foliofs/btrfs/extent_io.c+22 -200 replies
6/46btrfs: convert btrfs_do_readpage to only use a foliofs/btrfs/extent_io.c+29 -290 replies
7/46btrfs: update the writepage tracepoint to take a foliofs/btrfs/extent_io.c include/trace/events/btrfs.h+6 -60 replies
8/46btrfs: convert __extent_writepage_io to take a foliofs/btrfs/extent_io.c+25 -250 replies
9/46btrfs: convert extent_write_locked_range to use foliosfs/btrfs/extent_io.c+23 -130 replies
10/46btrfs: convert __extent_writepage to be completely folio basedfs/btrfs/extent_io.c+17 -180 replies
11/46btrfs: convert add_ra_bio_pages to use only foliosfs/btrfs/compression.c+33 -290 replies
12/46btrfs: utilize folio more in btrfs_page_mkwritefs/btrfs/file.c+12 -120 replies
13/46btrfs: convert can_finish_ordered_extent to use a foliofs/btrfs/ordered-data.c+11 -100 replies
14/46btrfs: convert btrfs_finish_ordered_extent to take a foliofs/btrfs/extent_io.c fs/btrfs/ordered-data.c fs/btrfs/ordered-data.h+6 -60 replies
15/46btrfs: convert btrfs_mark_ordered_io_finished to take a foliofs/btrfs/extent_io.c fs/btrfs/inode.c fs/btrfs/ordered-data.c +1 more+14 -140 replies
16/46btrfs: convert writepage_delalloc to take a foliofs/btrfs/extent_io.c+20 -180 replies
17/46btrfs: convert find_lock_delalloc_range to use a foliofs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/tests/extent-io-tests.c+20 -200 replies
18/46btrfs: convert lock_delalloc_pages to take a foliofs/btrfs/extent_io.c+11 -120 replies
19/46btrfs: convert __unlock_for_delalloc to take a foliofs/btrfs/extent_io.c+9 -90 replies
20/46btrfs: convert __process_pages_contig to take a foliofs/btrfs/extent_io.c+10 -90 replies
21/46btrfs: convert process_one_page to operate only on foliosfs/btrfs/extent_io.c+6 -80 replies
22/46btrfs: convert extent_clear_unlock_delalloc to take a foliofs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+18 -150 replies
23/46btrfs: convert extent_write_locked_range to take a foliofs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+5 -40 replies
24/46btrfs: convert run_delalloc_cow to take a foliofs/btrfs/inode.c+10 -100 replies
25/46btrfs: convert cow_file_range_inline to take a foliofs/btrfs/inode.c+6 -60 replies
26/46btrfs: convert cow_file_range to take a foliofs/btrfs/inode.c+21 -240 replies
27/46btrfs: convert fallback_to_cow to take a foliofs/btrfs/inode.c+8 -60 replies
28/46btrfs: convert run_delalloc_nocow to take a foliofs/btrfs/inode.c+8 -90 replies
29/46btrfs: convert btrfs_cleanup_ordered_extents to use foliosfs/btrfs/inode.c+6 -60 replies
30/46btrfs: convert btrfs_cleanup_ordered_extents to take a foliofs/btrfs/inode.c+14 -120 replies
31/46btrfs: convert run_delalloc_compressed to take a foliofs/btrfs/inode.c+11 -90 replies
32/46btrfs: convert btrfs_run_delalloc_range to take a foliofs/btrfs/btrfs_inode.h fs/btrfs/extent_io.c fs/btrfs/inode.c+14 -160 replies
33/46btrfs: convert async_chunk to hold a foliofs/btrfs/inode.c+14 -120 replies
34/46btrfs: convert submit_uncompressed_range to take a foliofs/btrfs/inode.c+12 -140 replies
35/46btrfs: convert btrfs_writepage_fixup_worker to use a foliofs/btrfs/inode.c+28 -260 replies
36/46btrfs: convert btrfs_writepage_cow_fixup to use foliofs/btrfs/btrfs_inode.h fs/btrfs/extent_io.c fs/btrfs/inode.c+18 -170 replies
37/46btrfs: convert btrfs_writepage_fixup to use a foliofs/btrfs/inode.c+3 -40 replies
38/46btrfs: convert uncompress_inline to take a foliofs/btrfs/inode.c+5 -40 replies
39/46btrfs: convert read_inline_extent to use a foliofs/btrfs/inode.c+7 -70 replies
40/46btrfs: convert btrfs_get_extent to take a foliofs/btrfs/btrfs_inode.h fs/btrfs/extent_io.c fs/btrfs/inode.c+5 -50 replies
41/46btrfs: convert __get_extent_map to take a foliofs/btrfs/extent_io.c+6 -50 replies
42/46btrfs: convert find_next_dirty_byte to take a foliofs/btrfs/extent_io.c+9 -90 replies
43/46btrfs: convert wait_subpage_spinlock to only use a foliofs/btrfs/inode.c+5 -60 replies
44/46btrfs: convert btrfs_set_range_writeback to use a foliofs/btrfs/inode.c+6 -60 replies
45/46btrfs: convert insert_inline_extent to use a foliofs/btrfs/inode.c+7 -40 replies
46/46btrfs: convert extent_range_clear_dirty_for_io to use a foliofs/btrfs/inode.c+6 -60 replies

Reviews trailers per patch

None of the 46 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Sterba
SeriesR-b
1/46
2/46
3/46
4/46
5/46
6/46
7/46
8/46
9/46
10/46
11/46
12/46
13/46
14/46
15/46
16/46
17/46
18/46
19/46
20/46
21/46
22/46
23/46
24/46
25/46
26/46
27/46
28/46
29/46
30/46
31/46
32/46
33/46
34/46
35/46
36/46
37/46
38/46
39/46
40/46
41/46
42/46
43/46
44/46
45/46
46/46

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/46] btrfs: convert most of the data path to use folios

Hello,

Willy indicated that he wants to get rid of page->index in the next merge window, so I went to look at what that would entail for btrfs, and I got a little carried away.

This patch series does in fact accomplish that, but it takes almost the entirety of the data write path and makes it work with only folios. I was going to convert everything, but there's some weird gaps that need to be handled in their own chunk.

1. Scrub. We're still passing around page pointers. Not a huge deal, it was just another 10ish patches just for that work, so I decided against it.

2. Buffered writes. Again, I did most of this work and it wasn't bad, but then I realized that the free space cache uses some of this code, and I really don't want to convert that code, I want to delete it, so I'll do that first.

3. Metadata. Qu has been doing this consistently and I didn't want to get in the way of his work so I just left most of that.

This has run through the CI and didn't cause any issues. I've made everything as easy to review as possible and as small as possible. My eyes started to glaze over a little bit with the changelogs, so let me know if there's anything you want changed. Thanks,

Josef

Josef Bacik (46):
btrfs: convert btrfs_readahead to only use folio
btrfs: convert btrfs_read_folio to only use a folio
btrfs: convert end_page_read to take a folio
btrfs: convert begin_page_folio to take a folio instead
btrfs: convert submit_extent_page to use a folio
btrfs: convert btrfs_do_readpage to only use a folio
btrfs: update the writepage tracepoint to take a folio
btrfs: convert __extent_writepage_io to take a folio
btrfs: convert extent_write_locked_range to use folios
btrfs: convert __extent_writepage to be completely folio based
btrfs: convert add_ra_bio_pages to use only folios
btrfs: utilize folio more in btrfs_page_mkwrite
btrfs: convert can_finish_ordered_extent to use a folio
btrfs: convert btrfs_finish_ordered_extent to take a folio
btrfs: convert btrfs_mark_ordered_io_finished to take a folio
btrfs: convert writepage_delalloc to take a folio
btrfs: convert find_lock_delalloc_range to use a folio
btrfs: convert lock_delalloc_pages to take a folio
btrfs: convert __unlock_for_delalloc to take a folio
btrfs: convert __process_pages_contig to take a folio
btrfs: convert process_one_page to operate only on folios
btrfs: convert extent_clear_unlock_delalloc to take a folio
btrfs: convert extent_write_locked_range to take a folio
btrfs: convert run_delalloc_cow to take a folio
btrfs: convert cow_file_range_inline to take a folio
btrfs: convert cow_file_range to take a folio
btrfs: convert fallback_to_cow to take a folio
btrfs: convert run_delalloc_nocow to take a folio
btrfs: convert btrfs_cleanup_ordered_extents to use folios
btrfs: convert btrfs_cleanup_ordered_extents to take a folio
btrfs: convert run_delalloc_compressed to take a folio
btrfs: convert btrfs_run_delalloc_range to take a folio
btrfs: convert async_chunk to hold a folio
btrfs: convert submit_uncompressed_range to take a folio
btrfs: convert btrfs_writepage_fixup_worker to use a folio
btrfs: convert btrfs_writepage_cow_fixup to use folio
btrfs: convert btrfs_writepage_fixup to use a folio
btrfs: convert uncompress_inline to take a folio
btrfs: convert read_inline_extent to use a folio
btrfs: convert btrfs_get_extent to take a folio
btrfs: convert __get_extent_map to take a folio
btrfs: convert find_next_dirty_byte to take a folio
btrfs: convert wait_subpage_spinlock to only use a folio
btrfs: convert btrfs_set_range_writeback to use a folio
btrfs: convert insert_inline_extent to use a folio
btrfs: convert extent_range_clear_dirty_for_io to use a folio

 fs/btrfs/btrfs_inode.h           |   6 +-
 fs/btrfs/compression.c           |  62 +++--
 fs/btrfs/extent_io.c             | 436 +++++++++++++++----------------
 fs/btrfs/extent_io.h             |   6 +-
 fs/btrfs/file.c                  |  24 +-
 fs/btrfs/inode.c                 | 342 ++++++++++++------------
 fs/btrfs/ordered-data.c          |  28 +-
 fs/btrfs/ordered-data.h          |   6 +-
 fs/btrfs/tests/extent-io-tests.c |  10 +-
 include/trace/events/btrfs.h     |  10 +-
 10 files changed, 467 insertions(+), 463 deletions(-)
Signature · 1 line
2.43.0